Allow theme override of non-magento composer themes

[pmclain]

Description (*)

This commit adjusts the editable theme filter to only exclued composer
themes in vendor/magento. All other themes installed via composer will
appear in the theme list when using the "Override this template in a
project theme" action.

Fixed Issues (if relevant)

1. Fixes Action/Code Generation. Override view file in a custom theme #64

Questions or comments

@VitaliyBoyko This resolves the feedback resulting in the reopening of #64, though I'm not sure it is a desirable feature. This change will add non-magento themes in vendor to the list of editable themes when using the override in theme action, but this already works for themes installed via composer locally if the local package exists within the project root directory. For example if you are installing a theme via path using symlinks as done in the example screenshot below prior to making this change.

The above is my personal preference for developing composer packages locally (pretty much verbatim following the Jisse's recommendation found here for anyone googling how to develop magento 2 composer packages locally https://www.yireo.com/blog/2019-05-10-local-composer-development-with-magento2) and this works with the existing implementation. I do know plenty of developers who will install a package via composer and replace the package contents when developing locally, this change would benefit developers using this workflow.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with integration/functional tests (if applicable)
• All automated tests passed successfully (all builds are green)

[coderimus]

Hello @pmclain ,
Thank you for the provided fix 👍 Please, provide the backport to the patch version.
Thank you,
Alex

[pmclain]

@coderimus backport PR #371