Added test coverage for PhpConstructorArgumentReferenceProvider #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpayyne
changed the title
drpayyne
force-pushed
the
tests-01
branch
2 times, most recently
from
995a61c to
908d470
Compare
VitaliyBoyko
pushed a commit
to drpayyne/magento2-phpstorm-plugin
that referenced
this pull request
Nov 11, 2020
Backport magento#386 Allow theme override of non-magento composer themes
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
VitaliyBoyko
added
Award: test coverage
Progress: ready for review
and removed
Progress: review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
|
@drpayyne please update the branch |
|
Done, @VitaliyBoyko. Thanks for your review. |
VitaliyBoyko
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added test coverage for
PhpConstructorArgumentReferenceProviderContribution checklist