Merge 1.3.0 - Add PHP 7.2 support #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update PHPUnit to version supported by PHP 7.2 * Fix unit tests for updated PHPUnit version
- added leading slashes
- removed old versions of PHP - updated PHPUnit to the latest version
Update PHPUnit and tests and add PHP 7.2 to composer.json
buskamuza
approved these changes
Mar 23, 2018
hostep
reviewed
Mar 23, 2018
composer.json
Outdated
| "composer/composer": "1.4.1", | ||
| "symfony/console": "~2.3, !=2.7.0" | ||
| "php": "~7.1.3|~7.2.0", | ||
| "composer/composer": "~1.6.0", |
There was a problem hiding this comment.
Since this PR was accepted: magento/magento2#14013
Shouldn't the composer constraint be changed to ^1.6 instead of ~1.6.0?
Otherwise composer won't upgrade to version 1.7 or 1.8 or higher when they are released, which was the purpose of the above mentioned PR.
/cc: @sandermangel, @miguelbalparda
Update composer/composer dependency
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Feb 7, 2024
AC-3684: Release magento components with symfony 5.4 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes magento-engcom/php-7.2-support#2
Source: magento-engcom/magento-composer-php-7.2-support#1