Update PHPUnit and tests and add PHP 7.2 to composer.json #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update PHPUnit to version supported by PHP 7.2 * Fix unit tests for updated PHPUnit version
buskamuza
approved these changes
Feb 13, 2018
This was referenced Feb 13, 2018
buskamuza
approved these changes
Feb 21, 2018
buskamuza
suggested changes
Feb 23, 2018
| "php": "~5.5.0|~5.6.0|~7.0.0|~7.1.0", | ||
| "composer/composer": "1.4.1", | ||
| "symfony/console": "~2.3, !=2.7.0" | ||
| "php": "~5.5.0|~5.6.0|~7.0.0|~7.1.0|~7.2.0", |
There was a problem hiding this comment.
As symfony/console supports PHP ~7.1.3, we should remove older versions from the list of supported here.
Also, need confirmation from @piotrekkaminski that it's ok to support PHP starting from 7.1.3. If not, we should upgrade to symfony 3 only.
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "4.1.0" | ||
| "phpunit/phpunit": "~6.2.0" |
There was a problem hiding this comment.
As PHPUnit 7 has been released, can we update to ~7.0.0? Looks like it doesn't cause dependency conflicts and tests pass.
|
Internal PR - magento/composer#11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes magento-engcom/php-7.2-support#2