Update PHPUnit and tests and add PHP 7.2 to composer.json #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update PHPUnit to version supported by PHP 7.2 * Fix unit tests for updated PHPUnit version
buskamuza
changed the title
paliarush
reviewed
Feb 22, 2018
tests/Composer/InfoCommandTest.php
Outdated
| protected function setUp() | ||
| { | ||
| $this->application = $this->getMock('Magento\Composer\MagentoComposerApplication', [], [], '', false, false); | ||
| $this->application = $this->createMock(Magento\Composer\MagentoComposerApplication::class); |
Contributor
There was a problem hiding this comment.
Why leading slash is removed everywhere?
- added leading slashes
- removed old versions of PHP - updated PHPUnit to the latest version
Contributor
|
✅ Changes look good. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jun 23, 2022
Update the package version to 1.9.0-beta1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes magento-engcom/php-7.2-support#2
Source: magento-engcom/magento-composer-php-7.2-support#1