Update Bindings for latest Upstream LDK #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, for the LDK `EventsProvider` trait, we can't (trivially) implement the `process_pending_events` function, defined as: `fn process_pending_events<H: Deref>(&self, handler: H) where H::Target: EventHandler;` We currently do not support implementing generic methods, as we'd need to wrap them in a generic Rust-trait-to-C-trait conversion utility, which we do not currently have. Thus, because users almost certainly have no reason to implement the `EventsProvider` themselves, its simpler to simply prevent the use of the C trait struct as the Rust trait. Concretely, this means just skipping the `impl rustEventsProvider for CEventsProvider` block, which works fine as no Rust functions take an `EventsProvider` as an argument.
This was referenced May 30, 2021
Contributor
|
Having difficulty running this on MacOS. + cd ..
+ mv lightning-c-bindings/src/c_types/mod.rs ./
+ mv lightning-c-bindings/src/bitcoin ./
+ git checkout lightning-c-bindings/src
+ git checkout lightning-c-bindings/include
++ git describe --tag --dirty
fatal: No names found, cannot describe anything.
+ BINDINGS_GIT= |
Getting the same error on #25 |
Contributor
|
Couple errors in error[E0053]: method `process_pending_events` has an incompatible type for trait
--> src/lightning/util/events.rs:1125:2
|
1125 | fn process_pending_events<H:core::ops::Deref>(&self, mut handler: crate::lightning::util::events::EventHandler) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected type parameter `H`, found struct `lightning::util::events::EventHandler`
|
= note: expected fn pointer `fn(&lightning::util::events::EventsProvider, H)`
found fn pointer `fn(&lightning::util::events::EventsProvider, lightning::util::events::EventHandler)`
error[E0055]: reached the recursion limit while auto-dereferencing `lightning::util::events::EventHandler`
--> src/lightning/util/events.rs:1126:56
|
1126 | (self.process_pending_events)(self.this_arg, handler.into())
| ^^^^ deref recursion limit reached
|
= help: consider adding a `#![recursion_limit="256"]` attribute to your crate (`ldk`)
error: aborting due to 2 previous errors |
Collaborator
Author
Huh, do you need |
jkczyz
reviewed
Jun 1, 2021
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Huh, do you need
git fetch --tags?
Same issue after running that.
c-bindings-gen/src/main.rs
Outdated
| let ref_type: syn::Type = syn::parse_quote!(&#path); | ||
| assert!(!types.write_to_c_conversion_new_var(w, &format_ident!("a"), &*i.self_ty, Some(&gen_types), false), "We don't support new var conversions when comparing equality"); | ||
|
|
||
| writeln!(w, "\t// Note that we'd love to use std::collections::hash_map::DefaultHasher but its not in core").unwrap(); |
Collaborator
Author
Right, oops, just forgot to check in the latest bindings, should work with genbindings.
Maybe |
Contributor
Yes, that worked. |
jkczyz
approved these changes
Jun 1, 2021
Collaborator
Author
|
Squashed the fixup and re-bumped the git head. Will merge if CI passes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.