Add new (C-not implementable) tag on EventsProvider
#934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that users cannot usefully implement their own `EventsProvider`, which would require substantial new logic in the bindings generator (for generic methods). In the case of `EventsProvider`, because there are no Rust methods which accept an `EventsProvider` as an argument, this is perfectly OK as the generated code would be entirely unused anyway.
Codecov Report
@@ Coverage Diff @@
## main #934 +/- ##
==========================================
- Coverage 90.55% 90.54% -0.01%
==========================================
Files 60 60
Lines 30698 30698
==========================================
- Hits 27798 27796 -2
- Misses 2900 2902 +2
Continue to review full report at Codecov.
|
jkczyz
approved these changes
May 31, 2021
valentinewallace
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that users cannot usefully implement their own
EventsProvider, which would require substantial new logic in thebindings generator (for generic methods). In the case of
EventsProvider, because there are no Rust methods which accept anEventsProvideras an argument, this is perfectly OK as thegenerated code would be entirely unused anyway.
LDK-C-Bindings PR which implements checking for the new tag is at lightningdevkit/ldk-c-bindings#24