Add background-processor to the with-std bindings #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Send+Sync are generated by the compiler for us, we don't really know when we should or should not generate it. That said, Send+Sync aren't exposed outside of Rust, so it only impacts whether we can use a type when passed to Rust, not how users will ultimately interact with types.
TheBlueMatt
force-pushed
the
2021-04-bp-inclusion
branch
from
b549a27 to
3edf2d5
Compare
Collaborator
Author
|
Rebased and added a few commits to improve clone-ability. |
valentinewallace
approved these changes
Jun 2, 2021
| /// [`FilesystemPersister::persist_manager`]: lightning_persister::FilesystemPersister::persist_manager | ||
| #[must_use] | ||
| #[no_mangle] | ||
| pub extern "C" fn BackgroundProcessor_start(mut persister: crate::lightning_background_processor::ChannelManagerPersister, mut event_handler: crate::lightning::util::events::EventHandler, chain_monitor: &crate::lightning::chain::chainmonitor::ChainMonitor, channel_manager: &crate::lightning::ln::channelmanager::ChannelManager, peer_manager: &crate::lightning::ln::peer_handler::PeerManager, mut logger: crate::lightning::util::logger::Logger) -> BackgroundProcessor { |
There was a problem hiding this comment.
Yay super excited for this to be exposed! I wonder how this is gonna reconcile with e.g. ChannelManagerPersister and other Java sample modules that currently are redundant to some of BackgroundProcessor's job?
Collaborator
Author
There was a problem hiding this comment.
My plan was to drop the similar Java wrappers entirely and move towards common wrappers, but still working on making it work sensibly with stop taking self ownership.
TheBlueMatt
force-pushed
the
2021-04-bp-inclusion
branch
from
3edf2d5 to
f0a481f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #24.