This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Klocwork fix PFW 3.1.0 #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pfw instance may use a logger after its deletion. This patch fixes it. Signed-off-by: Thomas Cahuzac <[email protected]>
A test consists in getting a value and testing it. But currently the value is tested even if the "get" has failed. This patch fixes it. Signed-off-by: Thomas Cahuzac <[email protected]>
tcahuzax
force-pushed
the
klocwork_fix_3.1.0
branch
2 times, most recently
from
8af936e to
a03539a
Compare
There was a problem hiding this comment.
You do not realy nead those std:: but it is more a matter of style.
tcahuzax
force-pushed
the
klocwork_fix_3.1.0
branch
from
a03539a to
89f1f17
Compare
This patch reworks the code to avoid using the memcpy function. Signed-off-by: Thomas Cahuzac <[email protected]>
tcahuzax
force-pushed
the
klocwork_fix_3.1.0
branch
from
284c2fe to
a01364e
Compare
This patch reworks the code to avoid calling the strncpy method, which is considered as unsafe on windows. Signed-off-by: Thomas Cahuzac <[email protected]>
tcahuzax
force-pushed
the
klocwork_fix_3.1.0
branch
from
a01364e to
563960d
Compare
|
plz review @krocard |
|
|
krocard
added a commit
that referenced
this pull request
Dec 29, 2015
Fix errors found by Klocwork on the PF 3.1.0 - Wrong instance lifetime - Using uninitialized variable - Avoiding using memcpy - Removing strncpy call
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::but it is more a matter of style.