Klocwork fix: removing strncpy call

This patch reworks the code to avoid calling
the strncpy method, which is considered as
unsafe on windows.

Signed-off-by: Thomas Cahuzac <[email protected]>

Author: tcahuzax

test/test-subsystem/TESTSubsystemString.cpp

@@ -28,6 +28,10 @@
 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 #include <string.h>
+#include <iterator>
+#include <algorithm>
+#include <stdexcept>
+#include <Iterator.hpp>
 #include "TESTSubsystemString.h"
 
 #define base CTESTSubsystemObject
@@ -46,5 +50,15 @@ std::string CTESTSubsystemString::toString(const void *pvValue, size_t /*size*/)
 
 void CTESTSubsystemString::fromString(const std::string &strValue, void *pvValue, size_t size)
 {
-    strncpy((char *)pvValue, strValue.c_str(), size);
+    std::size_t requiredBufferSize = strValue.length() + 1; /* Adding one for null character */
+    if (size < requiredBufferSize) {
+        throw std::logic_error("Buffer is to small: " + std::to_string(size) + " Minimum size: " +
+                               std::to_string(requiredBufferSize));
+    }
+
+    auto destination = MAKE_ARRAY_ITERATOR(static_cast<char *>(pvValue), size);
+    auto last = std::copy(begin(strValue), end(strValue), destination);
+
+    /* Adding null character */
+    *last = 0;
 }