Klocwork fix: Using uninitialized variable

tcahuzax · tcahuzax · commit 89f1f170ce69 · 2015-12-29T14:17:35.000+01:00
A test consists in getting a value and testing
it. But currently the value is tested even if
the "get" has failed.

This patch fixes it.

Signed-off-by: Thomas Cahuzac &lt;thomasx.cahuzac@intel.com&gt;
diff --git a/test/functional-tests/FloatingPoint.cpp b/test/functional-tests/FloatingPoint.cpp
@@ -99,7 +99,7 @@ SCENARIO_METHOD(FloatsPF, "Floating points", "[floating points]")
                     GIVEN ("A valid value " + vec.title) {
                         CHECK_NOTHROW(setParameter(path, vec.payload));
                         string getValueBack;
-                        CHECK_NOTHROW(getParameter(path, getValueBack));
+                        REQUIRE_NOTHROW(getParameter(path, getValueBack));
                         CHECK(getValueBack == vec.payload);
                     }
                 }
@@ -138,7 +138,7 @@ SCENARIO_METHOD(FloatsPF, "Floating points", "[floating points]")
                     GIVEN ("A valid value " + vec.title) {
                         CHECK_NOTHROW(setParameter(path, vec.payload));
                         string getValueBack;
-                        CHECK_NOTHROW(getParameter(path, getValueBack));
+                        REQUIRE_NOTHROW(getParameter(path, getValueBack));
                         CHECK(getValueBack == vec.payload);
                     }
                 }
@@ -161,7 +161,7 @@ SCENARIO_METHOD(FloatsPF, "Floating points", "[floating points]")
                     GIVEN ("A valid value " + vec.title) {
                         CHECK_NOTHROW(handle.setAsDouble(vec.payload));
                         double getValueBack;
-                        CHECK_NOTHROW(handle.getAsDouble(getValueBack));
+                        REQUIRE_NOTHROW(handle.getAsDouble(getValueBack));
                         CHECK(getValueBack == vec.payload);
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ SCENARIO_METHOD(FloatsPF, "Floating points", "[floating points]")`
`99`	`99`	`GIVEN ("A valid value " + vec.title) {`
`100`	`100`	`CHECK_NOTHROW(setParameter(path, vec.payload));`
`101`	`101`	`string getValueBack;`
`102`		`- CHECK_NOTHROW(getParameter(path, getValueBack));`
	`102`	`+ REQUIRE_NOTHROW(getParameter(path, getValueBack));`
`103`	`103`	`CHECK(getValueBack == vec.payload);`
`104`	`104`	`}`
`105`	`105`	`}`
`@@ -138,7 +138,7 @@ SCENARIO_METHOD(FloatsPF, "Floating points", "[floating points]")`
`138`	`138`	`GIVEN ("A valid value " + vec.title) {`
`139`	`139`	`CHECK_NOTHROW(setParameter(path, vec.payload));`
`140`	`140`	`string getValueBack;`
`141`		`- CHECK_NOTHROW(getParameter(path, getValueBack));`
	`141`	`+ REQUIRE_NOTHROW(getParameter(path, getValueBack));`
`142`	`142`	`CHECK(getValueBack == vec.payload);`
`143`	`143`	`}`
`144`	`144`	`}`
`@@ -161,7 +161,7 @@ SCENARIO_METHOD(FloatsPF, "Floating points", "[floating points]")`
`161`	`161`	`GIVEN ("A valid value " + vec.title) {`
`162`	`162`	`CHECK_NOTHROW(handle.setAsDouble(vec.payload));`
`163`	`163`	`double getValueBack;`
`164`		`- CHECK_NOTHROW(handle.getAsDouble(getValueBack));`
	`164`	`+ REQUIRE_NOTHROW(handle.getAsDouble(getValueBack));`
`165`	`165`	`CHECK(getValueBack == vec.payload);`
`166`	`166`	`}`
`167`	`167`	`}`