-
Notifications
You must be signed in to change notification settings - Fork 84
Add docs for new sys/billing/certificates endpoint #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rculpepper
wants to merge
124
commits into
main
Choose a base branch
from
rculpepper/pki-cert-count-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
We recently added a few more product usage metrics related to the number of dynamic and static roles. These need to be documented.
Documentation for this change: hashicorp/vault-plugin-secrets-kv#196 cc @robmonte for helping me with this new small feature ✨ cc https://github.com/github/glb/issues/7601
Co-authored-by: Sarah Chavis <[email protected]>
…unters.mdx Co-authored-by: Sarah Chavis <[email protected]>
…unters.mdx Co-authored-by: Sarah Chavis <[email protected]>
…period docs change (#697) Jira: https://hashicorp.atlassian.net/browse/VAULT-37796 Adds client_first_usage_time to export api Looks like token_creation_time ce changes are not present in this repo. Added those changes too https://github.com/hashicorp/vault/pull/31149/files
* add docs for datakeys endpoint * Apply suggestions from code review Co-authored-by: Sarah Chavis <[email protected]> --------- Co-authored-by: Sarah Chavis <[email protected]>
# secrets tune <img width="3456" height="5678" alt="image" src="https://github.com/user-attachments/assets/528e1370-4508-46e7-9c71-0a7383b50e7a" /> ### Added: GUI Steps <img width="1100" height="1080" alt="image" src="https://github.com/user-attachments/assets/1deb028e-a5ea-4279-beb4-ad131ed2f4c2" /> # Tune the lease time-to-live (TTL) <img width="3268" height="7649" alt="image" src="https://github.com/user-attachments/assets/a99cbe3a-31d8-4e85-acf5-5945bb5c4577" /> ### Added: GUI Steps <img width="1100" height="1080" alt="image" src="https://github.com/user-attachments/assets/1deb028e-a5ea-4279-beb4-ad131ed2f4c2" />
Vercel Previews Deployed
|
Correct partial paths for summary tables
schavis
requested changes
Oct 6, 2025
content/vault/v1.21.x (rc)/content/api-docs/system/billing-pki-certificate-count.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/billing-pki-certificate-count.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/billing-pki-certificate-count.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/billing-pki-certificate-count.mdx
Outdated
Show resolved
Hide resolved
### Request Parameters | ||
|
||
- `start_time` `(string: <required>)` - The first month for which to return certificate counts. | ||
The time must be a timestamp in RFC 3339 format (e.g., `2025-01-01T00:00:00Z` for January 2025). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
The time must be a timestamp in RFC 3339 format (e.g., `2025-01-01T00:00:00Z` for January 2025). | |
- `start_time` `(string: <required>)` - A timestamp in RFC 3339 format (e.g., | |
`2025-01-01T00:00:00Z` for January 2025) indicating the first month of the | |
query range. |
Style correction: use simple sentence construction
Comment on lines
+27
to
+28
- `end_time` `(string: <required>)` - The last month for which to return certificate counts. The `end_time` must not be before the `start_time`. | ||
The time must be a timestamp in RFC 3339 format (e.g., `2025-01-01T00:00:00Z` for January 2025). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- `end_time` `(string: <required>)` - The last month for which to return certificate counts. The `end_time` must not be before the `start_time`. | |
The time must be a timestamp in RFC 3339 format (e.g., `2025-01-01T00:00:00Z` for January 2025). | |
- `end_time` `(string: <required>)` - A timestamp in RFC 3339 format (e.g., | |
`2025-01-01T00:00:00Z` for January 2025) indicating the last month of the | |
query range. |
Edited to match start_time
content/vault/v1.21.x (rc)/content/api-docs/system/billing-pki-certificate-count.mdx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.