Skip to content

Vault Export api changes to add first used timestamp column in query period docs change #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 7, 2025

Conversation

akshya96
Copy link

@akshya96 akshya96 commented Aug 6, 2025

Jira: https://hashicorp.atlassian.net/browse/VAULT-37796
Adds client_first_usage_time to export api

Looks like token_creation_time ce changes are not present in this repo. Added those changes too https://github.com/hashicorp/vault/pull/31149/files

@akshya96 akshya96 requested a review from a team as a code owner August 6, 2025 20:21
Copy link

github-actions bot commented Aug 6, 2025

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Thu Aug 7 21:16:33 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Thu Aug 7 21:10:35 UTC 2025

Copy link
Contributor

@aslamovamir aslamovamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

github-actions bot commented Aug 6, 2025

Broken Link Checker

Full Github Actions output

Copy link

@gsantos-hc gsantos-hc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions, but otherwise looks good to me.

@akshya96 akshya96 requested a review from gsantos-hc August 6, 2025 23:21
@akshya96 akshya96 requested a review from schavis August 6, 2025 23:47
Copy link

@gsantos-hc gsantos-hc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akshya96
Copy link
Author

akshya96 commented Aug 7, 2025

It looks like token creation time is the creation time of the token that was used to perform the request for the client and this necessarily need not be the first ever token created for the client. I modified the description as part of commit 704966f

</Note>

- `client_first_usage_time` in the response is a timestamp that represents the earliest usage of the client during the queried time period.

- **`sudo` required** – This endpoint requires `sudo` capability in addition to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest deleting the sudo line in favor of using the restricted endpoint partial directly below the "Activity export" heading

Copy link
Author

@akshya96 akshya96 Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is more of a policy capability rather than a root-restricted endpoint

@akshya96 akshya96 requested a review from schavis August 7, 2025 20:56
@akshya96 akshya96 merged commit cd67a5b into vault/1.21.x Aug 7, 2025
8 of 9 checks passed
@akshya96 akshya96 deleted the vault-37796 branch August 7, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants