Add new Azure import params #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vercel Previews Deployed
|
Zlaticanin
changed the title
Broken Link CheckerNo broken links found! 🎉 |
schavis
requested changes
Sep 23, 2025
| - At least a `secret_id` must be provided to perform an import. | ||
| - You cannot provide a `client_secret` without a `secret_id`. | ||
| - If you provide an `expiration`, it must be a future time in RFC3339 format. | ||
| - `skip_import_rotation` has no effect on updates. |
There was a problem hiding this comment.
What does this mean? It doesn't seem like a validation rule to me
There was a problem hiding this comment.
I removed it since we cover most of these in our param descriptions.
|
@schavis Thank you for your review! I updated docs with your suggestions, could you please re-review when you get a chance? Thanks 🙏 |
schavis
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.