Skip to content

Conversation

@osa1
Copy link
Member

@osa1 osa1 commented May 19, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented May 19, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:protobuf 4.1.0 ready to publish protobuf-v4.1.0
package:protoc_plugin 22.2.0 ready to publish protoc_plugin-v22.2.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@osa1 osa1 requested a review from devoncarew May 19, 2025 09:31
@osa1 osa1 marked this pull request as ready for review May 19, 2025 09:31
Copy link
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

We should also mention in the changelogs for protobuf and protoc_plugin that the new min. sdk is 3.6.

@osa1
Copy link
Member Author

osa1 commented May 19, 2025

We should also mention in the changelogs for protobuf and protoc_plugin that the new min. sdk is 3.6.

Good point, do you know if this should be a major or minor version bump?

Technically it could break protobuf users and require them to bump Dart minor version, but bumping Dart minor version won't break any code. So I'm not sure if we consider this PR as breaking?

@devoncarew
Copy link
Contributor

Technically it could break protobuf users and require them to bump Dart minor version, but bumping Dart minor version won't break any code. So I'm not sure if we consider this PR as breaking?

I think we generally don't consider it breaking, but more something to note in the changelog. They'll still be able to solve in the previous publish, if they're doing something like running on a 3.5 SDK. You can probably just append to the current changelog entry (which is ready to publish).

WDYT about publishing after this and the deprecation annotation PR land? I'll have more changes this week, some of which will require minor version bumps (new API).

@osa1
Copy link
Member Author

osa1 commented May 19, 2025

Ah, I thought we already published the major versions as we don't have the -wip suffix. I updated the changelogs.

WDYT about publishing after this and the deprecation annotation PR land? I'll have more changes this week, some of which will require minor version bumps (new API).

SGTM.

];
...
```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block is indented so that it'll be a part of the bulleted list.

@osa1 osa1 merged commit 4960b92 into google:master May 19, 2025
16 checks passed
@osa1 osa1 deleted the pub_workspace branch May 19, 2025 16:22
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 19, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

protobuf (https://github.com/dart-lang/protobuf/compare/b7753f6..deda288):
  deda288  2025-05-19  Devon Carew  address a merge issue with the protoc_plugin changelog (google/protobuf.dart#1002)
  5ed4611  2025-05-19  Devon Carew  shorten the deprecation messages for clone() and copyWith() (google/protobuf.dart#999)
  4960b92  2025-05-19  Ömer Sinan Ağacan  Switch to pub workspace (google/protobuf.dart#1001)

test (https://github.com/dart-lang/test/compare/b9c59ea..5ffcb36):
  5ffcb36f  2025-05-19  Danny Tuppeny  Fix an issue with failed assertions using setUpAll/tearDownAll (dart-lang/test#2499)

Change-Id: Idc43e2f2fd9dc38b80917b25b45bb954076dc1c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429480
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants