Skip to content

Commit 4960b92

Browse files
authored
Switch to pub workspace (#1001)
1 parent b7753f6 commit 4960b92

File tree

8 files changed

+71
-60
lines changed

8 files changed

+71
-60
lines changed

.github/workflows/dart.yml

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -39,23 +39,23 @@ jobs:
3939
- name: mono_repo self validate
4040
run: dart pub global run mono_repo generate --validate
4141
job_002:
42-
name: "format_analyze; linux; Dart 3.3.0; PKG: protobuf; `dart analyze lib`, `dart analyze test`"
42+
name: "format_analyze; linux; Dart 3.6.0; PKG: protobuf; `dart analyze lib`, `dart analyze test`"
4343
runs-on: ubuntu-latest
4444
steps:
4545
- name: Cache Pub hosted dependencies
4646
uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684
4747
with:
4848
path: "~/.pub-cache/hosted"
49-
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf;commands:analyze_1-analyze_2"
49+
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:protobuf;commands:analyze_1-analyze_2"
5050
restore-keys: |
51-
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf
52-
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0
51+
os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:protobuf
52+
os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0
5353
os:ubuntu-latest;pub-cache-hosted
5454
os:ubuntu-latest
5555
- name: Setup Dart SDK
5656
uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
5757
with:
58-
sdk: "3.3.0"
58+
sdk: "3.6.0"
5959
- id: checkout
6060
name: Checkout repository
6161
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -191,23 +191,23 @@ jobs:
191191
if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'"
192192
working-directory: protoc_plugin
193193
job_006:
194-
name: "run_tests; linux; Dart 3.3.0; PKG: protobuf; `dart test`"
194+
name: "run_tests; linux; Dart 3.6.0; PKG: protobuf; `dart test`"
195195
runs-on: ubuntu-latest
196196
steps:
197197
- name: Cache Pub hosted dependencies
198198
uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684
199199
with:
200200
path: "~/.pub-cache/hosted"
201-
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf;commands:test"
201+
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:protobuf;commands:test"
202202
restore-keys: |
203-
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf
204-
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0
203+
os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:protobuf
204+
os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0
205205
os:ubuntu-latest;pub-cache-hosted
206206
os:ubuntu-latest
207207
- name: Setup Dart SDK
208208
uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
209209
with:
210-
sdk: "3.3.0"
210+
sdk: "3.6.0"
211211
- id: checkout
212212
name: Checkout repository
213213
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -227,23 +227,23 @@ jobs:
227227
- job_004
228228
- job_005
229229
job_007:
230-
name: "run_tests; linux; Dart 3.3.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test`"
230+
name: "run_tests; linux; Dart 3.6.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test`"
231231
runs-on: ubuntu-latest
232232
steps:
233233
- name: Cache Pub hosted dependencies
234234
uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684
235235
with:
236236
path: "~/.pub-cache/hosted"
237-
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protoc_plugin;commands:command_0-command_2-test"
237+
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:protoc_plugin;commands:command_0-command_2-test"
238238
restore-keys: |
239-
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protoc_plugin
240-
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0
239+
os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:protoc_plugin
240+
os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0
241241
os:ubuntu-latest;pub-cache-hosted
242242
os:ubuntu-latest
243243
- name: Setup Dart SDK
244244
uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
245245
with:
246-
sdk: "3.3.0"
246+
sdk: "3.6.0"
247247
- id: checkout
248248
name: Checkout repository
249249
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -351,23 +351,23 @@ jobs:
351351
- job_004
352352
- job_005
353353
job_010:
354-
name: "run_tests; osx; Dart 3.3.0; PKG: protobuf; `dart test`"
354+
name: "run_tests; osx; Dart 3.6.0; PKG: protobuf; `dart test`"
355355
runs-on: macos-latest
356356
steps:
357357
- name: Cache Pub hosted dependencies
358358
uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684
359359
with:
360360
path: "~/.pub-cache/hosted"
361-
key: "os:macos-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf;commands:test"
361+
key: "os:macos-latest;pub-cache-hosted;sdk:3.6.0;packages:protobuf;commands:test"
362362
restore-keys: |
363-
os:macos-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf
364-
os:macos-latest;pub-cache-hosted;sdk:3.3.0
363+
os:macos-latest;pub-cache-hosted;sdk:3.6.0;packages:protobuf
364+
os:macos-latest;pub-cache-hosted;sdk:3.6.0
365365
os:macos-latest;pub-cache-hosted
366366
os:macos-latest
367367
- name: Setup Dart SDK
368368
uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
369369
with:
370-
sdk: "3.3.0"
370+
sdk: "3.6.0"
371371
- id: checkout
372372
name: Checkout repository
373373
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -423,13 +423,13 @@ jobs:
423423
- job_004
424424
- job_005
425425
job_012:
426-
name: "run_tests; windows; Dart 3.3.0; PKG: protobuf; `dart test`"
426+
name: "run_tests; windows; Dart 3.6.0; PKG: protobuf; `dart test`"
427427
runs-on: windows-latest
428428
steps:
429429
- name: Setup Dart SDK
430430
uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
431431
with:
432-
sdk: "3.3.0"
432+
sdk: "3.6.0"
433433
- id: checkout
434434
name: Checkout repository
435435
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683

benchmarks/pubspec.yaml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ description: Benchmarks for various protobuf functions.
77
publish_to: none
88

99
environment:
10-
sdk: '>=2.19.0 <3.0.0'
10+
sdk: '^3.6.0'
11+
12+
resolution: workspace
1113

1214
dependencies:
1315
# NB. When bumping benchmark_harness check if `benchmark_base.BenchmarkBase`
@@ -24,7 +26,3 @@ dev_dependencies:
2426
pool: ^1.5.1
2527
protoc_plugin:
2628
path: '../protoc_plugin'
27-
28-
dependency_overrides:
29-
protobuf:
30-
path: "../protobuf"

protobuf/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
## 4.1.0
22

33
* Improve packed field decoding performance. ([#959], [#981])
4+
* Minimum SDK dependency bumped from 3.3.0 to 3.6.0. ([#1001])
45

56
[#959]: https://github.com/google/protobuf.dart/pull/959
67
[#981]: https://github.com/google/protobuf.dart/pull/981
8+
[#1001]: https://github.com/google/protobuf.dart/pull/1001
79

810
## 4.0.0
911

protobuf/pubspec.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ description: >-
66
repository: https://github.com/google/protobuf.dart/tree/master/protobuf
77

88
environment:
9-
sdk: '>=3.3.0 <4.0.0'
9+
sdk: '^3.6.0'
10+
11+
resolution: workspace
1012

1113
dependencies:
1214
collection: ^1.15.0

protoc_plugin/CHANGELOG.md

Lines changed: 30 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -5,36 +5,38 @@
55
and write that information to the generated gRPC clients.
66
* Generate dartdocs for grpc services ([#973]).
77

8-
We now parse and generate code cooresponding to the proto options
9-
`google.api.default_host` and `google.api.oauth_scopes`:
10-
11-
```proto
12-
service Firestore {
13-
option (google.api.default_host) = "firestore.googleapis.com";
14-
option (google.api.oauth_scopes) =
15-
"https://www.googleapis.com/auth/cloud-platform,"
16-
"https://www.googleapis.com/auth/datastore";
17-
18-
...
19-
```
20-
21-
Will generate as:
22-
23-
```dart
24-
class FirestoreClient extends $grpc.Client {
25-
/// The hostname for this service.
26-
static const $core.String defaultHost = 'firestore.googleapis.com';
27-
28-
/// OAuth scopes needed for the client.
29-
static const $core.List<$core.String> oauthScopes = [
30-
'https://www.googleapis.com/auth/cloud-platform',
31-
'https://www.googleapis.com/auth/datastore',
32-
];
33-
34-
...
35-
```
8+
We now parse and generate code cooresponding to the proto options
9+
`google.api.default_host` and `google.api.oauth_scopes`:
10+
11+
```proto
12+
service Firestore {
13+
option (google.api.default_host) = "firestore.googleapis.com";
14+
option (google.api.oauth_scopes) =
15+
"https://www.googleapis.com/auth/cloud-platform,"
16+
"https://www.googleapis.com/auth/datastore";
17+
18+
...
19+
```
20+
21+
Will generate as:
22+
23+
```dart
24+
class FirestoreClient extends $grpc.Client {
25+
/// The hostname for this service.
26+
static const $core.String defaultHost = 'firestore.googleapis.com';
27+
28+
/// OAuth scopes needed for the client.
29+
static const $core.List<$core.String> oauthScopes = [
30+
'https://www.googleapis.com/auth/cloud-platform',
31+
'https://www.googleapis.com/auth/datastore',
32+
];
33+
34+
...
35+
```
36+
* Minimum SDK dependency bumped from 3.3.0 to 3.6.0. ([#1001])
3637

3738
[#973]: https://github.com/google/protobuf.dart/issues/973
39+
[#1001]: https://github.com/google/protobuf.dart/pull/1001
3840

3941
## 22.1.0
4042

protoc_plugin/pubspec.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ description: A protobuf protoc compiler plugin used to generate Dart code.
44
repository: https://github.com/google/protobuf.dart/tree/master/protoc_plugin
55

66
environment:
7-
sdk: '>=3.3.0 <4.0.0'
7+
sdk: '^3.6.0'
8+
9+
resolution: workspace
810

911
dependencies:
1012
collection: ^1.15.0

protoc_plugin/pubspec_overrides.yaml

Lines changed: 0 additions & 3 deletions
This file was deleted.

pubspec.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
name: _
2+
publish_to: none
3+
environment:
4+
sdk: ^3.6.0
5+
workspace:
6+
- benchmarks
7+
- protobuf
8+
- protoc_plugin

0 commit comments

Comments
 (0)