Skip to content

Conversation

@osa1
Copy link
Member

@osa1 osa1 commented May 16, 2025

It's more common to have the overrides in the main pubspec.

@osa1 osa1 requested a review from devoncarew May 16, 2025 08:23
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:protobuf 4.0.1-wip WIP (no publish necessary)
package:protoc_plugin 22.2.0 ready to publish protoc_plugin-v22.2.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

We can also switch to using the newer pub workspace support. There wouldn't be any downsides for this repo and we could remove the overrides completely.

@osa1
Copy link
Member Author

osa1 commented May 19, 2025

We can also switch to using the newer pub workspace support. There wouldn't be any downsides for this repo and we could remove the overrides completely.

Makes sense, done in #1001.

@osa1 osa1 closed this May 19, 2025
@osa1 osa1 deleted the delete_pubspec_overrides branch May 19, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants