Skip to content

Conversation

silverwind
Copy link
Member

Replaces and includes #19758.

Makes all buttons/labels use primary class instead of blue. There were a few cases where secondary was more appropriate and I fixed the styling for it as well.

@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label May 19, 2022
@silverwind silverwind added this to the 1.17.0 milestone May 19, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 19, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 19, 2022
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--color-blue-dark is not what it means, otherwise LGTM.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 19, 2022
@silverwind
Copy link
Member Author

silverwind commented May 19, 2022

--color-blue-dark is not what it means, otherwise LGTM.

Fixed in ca49f0d which adds all light color variants.

For reference, it was produced on https://www.sassmeister.com/ using this source:

:root {
    --color-red-light: #{scale-color(#db2828, $lightness: +25%)};
    --color-orange-light: #{scale-color(#f2711c, $lightness: +25%)};
    --color-yellow-light: #{scale-color(#fbbd08, $lightness: +25%)};
    --color-olive-light: #{scale-color(#b5cc18, $lightness: +25%)};
    --color-green-light: #{scale-color(#21ba45, $lightness: +25%)};
    --color-teal-light: #{scale-color(#00b5ad, $lightness: +25%)};
    --color-blue-light: #{scale-color(#2185d0, $lightness: +25%)};
    --color-violet-light: #{scale-color(#6435c9, $lightness: +25%)};
    --color-purple-light: #{scale-color(#a333c8, $lightness: +25%)};
    --color-pink-light: #{scale-color(#e03997, $lightness: +25%)};
    --color-brown-light: #{scale-color(#a5673f, $lightness: +25%)};
    --color-grey-light: #{scale-color(#888888, $lightness: +25%)};
    --color-gold-light: #{scale-color(#a1882b, $lightness: +25%)};
}

@6543
Copy link
Member

6543 commented May 19, 2022

🚀

@6543 6543 merged commit 9da3d78 into go-gitea:main May 19, 2022
@silverwind silverwind deleted the blue branch May 20, 2022 08:23
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 20, 2022
* giteaofficial/main:
  Move org functions (go-gitea#19753)
  [doctor] pq: syntax error at or near "." quote user table name (go-gitea#19765)
  [doctor] update the help with fix capabilities (go-gitea#19762)
  Remove fomantic progress module (go-gitea#19760)
  Make Ctrl+Enter (quick submit) work for issue comment and wiki editor (go-gitea#19729)
  Enable packages by default again (as described by docs) (go-gitea#19746)
  Replace blue button and label classes with primary (go-gitea#19763)
  Fix org package owner permissions (go-gitea#19742)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* make blue really blue

* replace blue button and label classes with primary

* add --color-blue-dark

* add light color variants, tweak a few colors

* fix colors

* add comment

Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants