Skip to content

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented May 18, 2022

Addition to #19735 to fix #19583.
Old code did not respect owner visibility and the organization access calculation was wrong if the user was not a member.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 18, 2022
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 18, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2022
@6543
Copy link
Member

6543 commented May 18, 2022

@KN4CK3R this permissions should be checked via integration tests ... so we do check the whole stack ...

@6543
Copy link
Member

6543 commented May 19, 2022

🚀

@6543 6543 merged commit ce52514 into go-gitea:main May 19, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 20, 2022
* giteaofficial/main:
  Move org functions (go-gitea#19753)
  [doctor] pq: syntax error at or near "." quote user table name (go-gitea#19765)
  [doctor] update the help with fix capabilities (go-gitea#19762)
  Remove fomantic progress module (go-gitea#19760)
  Make Ctrl+Enter (quick submit) work for issue comment and wiki editor (go-gitea#19729)
  Enable packages by default again (as described by docs) (go-gitea#19746)
  Replace blue button and label classes with primary (go-gitea#19763)
  Fix org package owner permissions (go-gitea#19742)
@KN4CK3R KN4CK3R deleted the fix-19583-2 branch May 21, 2022 11:04
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
Old code did not respect owner visibility and the organization access calculation was wrong if the user was not a member.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/packages type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container registry (docker) ask credential for pull
4 participants