Remove fomantic progress module #19760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace it with HTML `<progress>` element. The bar won't go green at 100% anymore but I think it's not something that fits stylistically anyways.
lunny
approved these changes
May 20, 2022
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
May 20, 2022
GiteaBot
added
lgtm/done
|
Will this make the progress green? |
|
It seems working. https://jsfiddle.net/k8rjmaqu/ (it's just a personal opinion to make 100% as green, in case some people like it, I am fine to either. not a blocker)
|
wxiaoguang
approved these changes
May 20, 2022
Yes it would work for the case where max is 100 like it is for the milestone bar, but I think we could also opt to make the milestone bar always green, like GitHub does. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 20, 2022
* giteaofficial/main: Move org functions (go-gitea#19753) [doctor] pq: syntax error at or near "." quote user table name (go-gitea#19765) [doctor] update the help with fix capabilities (go-gitea#19762) Remove fomantic progress module (go-gitea#19760) Make Ctrl+Enter (quick submit) work for issue comment and wiki editor (go-gitea#19729) Enable packages by default again (as described by docs) (go-gitea#19746) Replace blue button and label classes with primary (go-gitea#19763) Fix org package owner permissions (go-gitea#19742)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
Replace it with HTML `<progress>` element. The bar won't go green at 100% anymore but I think it's not something that fits stylistically anyways.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace it with HTML
<progress>element. The bar won't animate or go green at 100% anymore but I think it's not something that fits stylistically anyways.