Skip to content

Uncapitalize errors #18915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2022
Merged

Uncapitalize errors #18915

merged 2 commits into from
Feb 26, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Feb 26, 2022

@Gusted Gusted added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 26, 2022
@Gusted Gusted added this to the 1.17.0 milestone Feb 26, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 26, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #18915 (81526a1) into main (fa0e2d6) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18915      +/-   ##
==========================================
+ Coverage   46.62%   46.64%   +0.02%     
==========================================
  Files         854      854              
  Lines      122561   122561              
==========================================
+ Hits        57144    57171      +27     
+ Misses      58521    58493      -28     
- Partials     6896     6897       +1
Impacted Files Coverage Δ
routers/web/repo/issue.go 37.81% <0.00%> (ø)
routers/web/repo/lfs.go 0.00% <0.00%> (ø)
routers/web/repo/webhook.go 1.00% <0.00%> (ø)
modules/process/manager.go 81.36% <0.00%> (-1.87%) ⬇️
services/pull/pull.go 40.24% <0.00%> (+0.46%) ⬆️
modules/queue/workerpool.go 55.35% <0.00%> (+2.08%) ⬆️
modules/queue/queue_channel.go 81.13% <0.00%> (+2.83%) ⬆️
modules/queue/queue_bytefifo.go 52.72% <0.00%> (+5.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0e2d6...81526a1. Read the comment docs.

@lunny lunny merged commit 6d55a13 into go-gitea:main Feb 26, 2022
@Gusted Gusted deleted the decapitalize-errors branch February 26, 2022 12:15
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 27, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
835165e 
* giteaofficial/main:
  Fix page and missing return on unadopted repos API (go-gitea#18848)
  [skip ci] Updated licenses and gitignores
  Allow adminstrator teams members to see other teams (go-gitea#18918)
  Update nginx reverse proxy docs (go-gitea#18922)
  Don't treat BOM escape sequence as hidden character. (go-gitea#18909)
  Remove CodeMirror dependencies (go-gitea#18911)
  Uncapitalize errors (go-gitea#18915)
  Disable service worker by default (go-gitea#18914)
  Set is_empty in fixtures (go-gitea#18869)
  Don't update email for organisation (go-gitea#18905)
  Correctly link URLs to users/repos with dashes, dots or underscores (go-gitea#18890)
  Set is_private in fixtures. (go-gitea#18868)
  Fix team management UI (go-gitea#18886)
  Update JS dependencies (go-gitea#18898)
  Fix migration v210 (go-gitea#18892)
  migrations: add test for importing pull requests in gitea uploader (go-gitea#18752)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Uncapitalize errors (go-gitea#18915)
bc5dfc9 
- See: https://github.com/golang/go/wiki/CodeReviewComments#error-strings

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Gusted @codecov-commenter @silverwind @KN4CK3R @lunny @GiteaBot