Skip to content

Fix migration v210 #18892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2022
Merged

Fix migration v210 #18892

merged 1 commit into from
Feb 25, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 25, 2022

Fix #18881
Fix #18889

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.16 labels Feb 25, 2022
@lunny lunny mentioned this pull request Feb 25, 2022
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 25, 2022
@lunny lunny force-pushed the lunny/fix_migrate_v210 branch from a149a53 to 9fbe349 Compare February 25, 2022 09:40
@singuliere
Copy link
Contributor

The CI failure does not seem to be related

2022/02/25 09:43:50 ...eue/queue_channel.go:153:func1() [W] ChannelQueue:  Terminated before completed flushing

2022/02/25 09:43:50 ...eue/queue_channel.go:153:func1() [W] ChannelQueue: second-channel Terminated before completed flushing

panic: runtime error: invalid memory address or nil pointer dereference

[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa79901]


goroutine 79 [running]:

github.com/syndtr/goleveldb/leveldb.(*DB).isClosed(...)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 25, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 25, 2022
@6543
Copy link
Member

6543 commented Feb 25, 2022 •
edited
Loading

@singuliere no ... a restart did let it pass - in any case how should a search queue issue be related to migration fix?!?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2022
@6543 6543 merged commit a5e8dae into go-gitea:main Feb 25, 2022
@lunny lunny deleted the lunny/fix_migrate_v210 branch February 25, 2022 14:10
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 27, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
835165e 
* giteaofficial/main:
  Fix page and missing return on unadopted repos API (go-gitea#18848)
  [skip ci] Updated licenses and gitignores
  Allow adminstrator teams members to see other teams (go-gitea#18918)
  Update nginx reverse proxy docs (go-gitea#18922)
  Don't treat BOM escape sequence as hidden character. (go-gitea#18909)
  Remove CodeMirror dependencies (go-gitea#18911)
  Uncapitalize errors (go-gitea#18915)
  Disable service worker by default (go-gitea#18914)
  Set is_empty in fixtures (go-gitea#18869)
  Don't update email for organisation (go-gitea#18905)
  Correctly link URLs to users/repos with dashes, dots or underscores (go-gitea#18890)
  Set is_private in fixtures. (go-gitea#18868)
  Fix team management UI (go-gitea#18886)
  Update JS dependencies (go-gitea#18898)
  Fix migration v210 (go-gitea#18892)
  migrations: add test for importing pull requests in gitea uploader (go-gitea#18752)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Fix migration v210 (go-gitea#18892)
3d82dda
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@noerw noerw noerw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrading to 1.16.2 does not work Upgrade to 1.16.2 failed , due to database migration issue
5 participants
@lunny @singuliere @6543 @noerw @GiteaBot