migrations: add test for importing pull requests in gitea uploader #18752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2022 17:59
Signed-off-by: Loïc Dachary <[email protected]>
Signed-off-by: Loïc Dachary <[email protected]>
lunny
reviewed
Feb 14, 2022
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Feb 14, 2022
GiteaBot
added
lgtm/need 1
singuliere
added
the
topic/repo-migration
Codecov Report
@@ Coverage Diff @@
## main #18752 +/- ##
==========================================
- Coverage 46.64% 46.63% -0.01%
==========================================
Files 846 854 +8
Lines 121331 122516 +1185
==========================================
+ Hits 56595 57136 +541
- Misses 57859 58490 +631
- Partials 6877 6890 +13
Continue to review full report at Codecov.
|
Gusted
reviewed
Feb 22, 2022
Gusted
approved these changes
Feb 23, 2022
GiteaBot
added
lgtm/done
|
make l-g-t-m work |
|
make l-g-t-m work |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 27, 2022
* giteaofficial/main: Fix page and missing return on unadopted repos API (go-gitea#18848) [skip ci] Updated licenses and gitignores Allow adminstrator teams members to see other teams (go-gitea#18918) Update nginx reverse proxy docs (go-gitea#18922) Don't treat BOM escape sequence as hidden character. (go-gitea#18909) Remove CodeMirror dependencies (go-gitea#18911) Uncapitalize errors (go-gitea#18915) Disable service worker by default (go-gitea#18914) Set is_empty in fixtures (go-gitea#18869) Don't update email for organisation (go-gitea#18905) Correctly link URLs to users/repos with dashes, dots or underscores (go-gitea#18890) Set is_private in fixtures. (go-gitea#18868) Fix team management UI (go-gitea#18886) Update JS dependencies (go-gitea#18898) Fix migration v210 (go-gitea#18892) migrations: add test for importing pull requests in gitea uploader (go-gitea#18752)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…o-gitea#18752) * logs: add the buffer logger to inspect logs during testing Signed-off-by: Loïc Dachary <[email protected]> * migrations: add test for importing pull requests in gitea uploader Signed-off-by: Loïc Dachary <[email protected]> * for each git.OpenRepositoryCtx, call Close * Content is expected to return the content of the log * test for errors before defer Co-authored-by: Loïc Dachary <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See original merge request from Loïc Dachary @ forgefriends
The
gitea_uploader.gois modified in a minimal way to move around 100 lines to theupdateGitForPullRequest, the code logic is otherwise not modified. Tests are written to provide 100% coverage, except for the system errors fromos.Createetc.