-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(autofix): Fix automation onboarding condition #92579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennmueng
approved these changes
May 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92579 +/- ##
==========================================
- Coverage 87.89% 87.89% -0.01%
==========================================
Files 10237 10237
Lines 587023 587022 -1
Branches 22806 22805 -1
==========================================
- Hits 515937 515936 -1
Misses 70660 70660
Partials 426 426 |
jan-auer
added a commit
that referenced
this pull request
Jun 2, 2025
* master: (249 commits) feat(source-maps): Do not show pagination together with empty state (#92287) ref(project-creation): Introduce useCreateProjectRules hook (#92186) feat(agent-insights): Handle new keys (#92613) feat(source-maps): Introduce new empty state copies and react-native callout (#92286) ref(issues): Remove project from group activity type (#92600) feat(ourlogs): Use /trace-logs endpoint (#92577) feat(issues): Only update group hasSeen when user is member (#92597) fix(workflow_engine): Graceful Data Condition Eval Handling (#92591) feat(uptime): Implement detector handler (#91107) chore(autofix): Remove logs from response payload (#92589) fix(search): Fix issue with tags name 'constructor' (#92586) fix(autofix): Fix condition for onboarding check (#92584) fix(ourlogs): Return the same format as /events & limit 1000 for trace-logs (#92580) fix(autofix): Fix automation onboarding condition (#92579) feat(explore): Remove group by timestamp from explore (#92546) feat(trace-items): Autocomplete for semver attributes (#92515) feat(processing) Define EventProcessingStore.__all__ (#92555) feat(autofix): Better errored state (#92571) chore(autofix): Seer beta banner copy changes (#92576) feat(crons): Add endpoint to return counts by status (#92574) ...
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
We were accidentally marking the automation step in onboarding as complete. Missing an undefined check. Also add check for FF for starred views
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were accidentally marking the automation step in onboarding as complete. Missing an undefined check.
Also add check for FF for starred views