Skip to content

Conversation

@roaga
Copy link
Member

@roaga roaga commented May 30, 2025

We were accidentally marking the automation step in onboarding as complete. Missing an undefined check.
Also add check for FF for starred views

@roaga roaga requested a review from jennmueng May 30, 2025 19:16
@roaga roaga requested a review from a team as a code owner May 30, 2025 19:16
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 30, 2025
Copy link
Member

@jennmueng jennmueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92579      +/-   ##
==========================================
- Coverage   87.89%   87.89%   -0.01%     
==========================================
  Files       10237    10237              
  Lines      587023   587022       -1     
  Branches    22806    22805       -1     
==========================================
- Hits       515937   515936       -1     
  Misses      70660    70660              
  Partials      426      426              

@roaga roaga merged commit afae371 into master May 30, 2025
43 checks passed
@roaga roaga deleted the autofix/automation-onboarding-condition branch May 30, 2025 19:56
jan-auer added a commit that referenced this pull request Jun 2, 2025
* master: (249 commits)
  feat(source-maps): Do not show pagination together with empty state (#92287)
  ref(project-creation): Introduce useCreateProjectRules hook (#92186)
  feat(agent-insights): Handle new keys (#92613)
  feat(source-maps): Introduce new empty state copies and react-native callout (#92286)
  ref(issues): Remove project from group activity type (#92600)
  feat(ourlogs): Use /trace-logs endpoint (#92577)
  feat(issues): Only update group hasSeen when user is member (#92597)
  fix(workflow_engine): Graceful Data Condition Eval Handling (#92591)
  feat(uptime): Implement detector handler (#91107)
  chore(autofix): Remove logs from response payload (#92589)
  fix(search): Fix issue with tags name 'constructor' (#92586)
  fix(autofix): Fix condition for onboarding check (#92584)
  fix(ourlogs): Return the same format as /events & limit 1000 for trace-logs (#92580)
  fix(autofix): Fix automation onboarding condition (#92579)
  feat(explore): Remove group by timestamp from explore (#92546)
  feat(trace-items): Autocomplete for semver attributes (#92515)
  feat(processing) Define EventProcessingStore.__all__ (#92555)
  feat(autofix): Better errored state (#92571)
  chore(autofix): Seer beta banner copy changes (#92576)
  feat(crons): Add endpoint to return counts by status (#92574)
  ...
andrewshie-sentry pushed a commit that referenced this pull request Jun 2, 2025
We were accidentally marking the automation step in onboarding as
complete. Missing an undefined check.
Also add check for FF for starred views
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants