Skip to content

Conversation

@markstory
Copy link
Member

The base Service class requires __all__ to be defined for metrics to be collected on methods. I missed that in #92447

The base `Service` class requires `__all__` to be defined for metrics to
be collected on methods. I missed that in #92447
@markstory markstory requested review from a team May 30, 2025 16:22
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 30, 2025
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92555      +/-   ##
==========================================
- Coverage   87.89%   87.89%   -0.01%     
==========================================
  Files       10236    10236              
  Lines      586985   586986       +1     
  Branches    22805    22805              
==========================================
- Hits       515935   515922      -13     
- Misses      70620    70634      +14     
  Partials      430      430              

@markstory markstory merged commit 36d682f into master May 30, 2025
62 checks passed
@markstory markstory deleted the feat-processingstore-metrics branch May 30, 2025 19:42
jan-auer added a commit that referenced this pull request Jun 2, 2025
* master: (249 commits)
  feat(source-maps): Do not show pagination together with empty state (#92287)
  ref(project-creation): Introduce useCreateProjectRules hook (#92186)
  feat(agent-insights): Handle new keys (#92613)
  feat(source-maps): Introduce new empty state copies and react-native callout (#92286)
  ref(issues): Remove project from group activity type (#92600)
  feat(ourlogs): Use /trace-logs endpoint (#92577)
  feat(issues): Only update group hasSeen when user is member (#92597)
  fix(workflow_engine): Graceful Data Condition Eval Handling (#92591)
  feat(uptime): Implement detector handler (#91107)
  chore(autofix): Remove logs from response payload (#92589)
  fix(search): Fix issue with tags name 'constructor' (#92586)
  fix(autofix): Fix condition for onboarding check (#92584)
  fix(ourlogs): Return the same format as /events & limit 1000 for trace-logs (#92580)
  fix(autofix): Fix automation onboarding condition (#92579)
  feat(explore): Remove group by timestamp from explore (#92546)
  feat(trace-items): Autocomplete for semver attributes (#92515)
  feat(processing) Define EventProcessingStore.__all__ (#92555)
  feat(autofix): Better errored state (#92571)
  chore(autofix): Seer beta banner copy changes (#92576)
  feat(crons): Add endpoint to return counts by status (#92574)
  ...
andrewshie-sentry pushed a commit that referenced this pull request Jun 2, 2025
The base `Service` class requires `__all__` to be defined for metrics to
be collected on methods. I missed that in #92447
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants