ref(project-creation): Introduce useCreateProjectRules hook #92186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
commented
May 23, 2025
Comment on lines
7
to
15
| interface Variables | ||
| extends Partial< | ||
| Pick< | ||
| RequestDataFragment, | ||
| 'conditions' | 'actions' | 'actionMatch' | 'frequency' | 'name' | ||
| > | ||
| > { | ||
| projectSlug: string; | ||
| } |
There was a problem hiding this comment.
we should also improve the types here and make it reusable. but step-by-step
…e-create-project-rules-hook
…ect-rules-hook' of github.com:getsentry/sentry into priscila/ref/project-creation/introduce-use-create-project-rules-hook
malwilley
reviewed
May 27, 2025
| } | ||
|
|
||
| export function useCreateProjectRules() { | ||
| const api = useApi(); |
There was a problem hiding this comment.
For mutations, usually best to add persistInFlight: true
malwilley
approved these changes
May 27, 2025
…e-create-project-rules-hook
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92186 +/- ##
==========================================
- Coverage 87.89% 86.80% -1.09%
==========================================
Files 10239 10170 -69
Lines 587425 582350 -5075
Branches 22812 22513 -299
==========================================
- Hits 516312 505528 -10784
- Misses 70683 76376 +5693
- Partials 430 446 +16 |
…e-create-project-rules-hook
priscilawebdev
deleted the
priscila/ref/project-creation/introduce-use-create-project-rules-hook
branch
jan-auer
added a commit
that referenced
this pull request
Jun 2, 2025
* master: (249 commits) feat(source-maps): Do not show pagination together with empty state (#92287) ref(project-creation): Introduce useCreateProjectRules hook (#92186) feat(agent-insights): Handle new keys (#92613) feat(source-maps): Introduce new empty state copies and react-native callout (#92286) ref(issues): Remove project from group activity type (#92600) feat(ourlogs): Use /trace-logs endpoint (#92577) feat(issues): Only update group hasSeen when user is member (#92597) fix(workflow_engine): Graceful Data Condition Eval Handling (#92591) feat(uptime): Implement detector handler (#91107) chore(autofix): Remove logs from response payload (#92589) fix(search): Fix issue with tags name 'constructor' (#92586) fix(autofix): Fix condition for onboarding check (#92584) fix(ourlogs): Return the same format as /events & limit 1000 for trace-logs (#92580) fix(autofix): Fix automation onboarding condition (#92579) feat(explore): Remove group by timestamp from explore (#92546) feat(trace-items): Autocomplete for semver attributes (#92515) feat(processing) Define EventProcessingStore.__all__ (#92555) feat(autofix): Better errored state (#92571) chore(autofix): Seer beta banner copy changes (#92576) feat(crons): Add endpoint to return counts by status (#92574) ...
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
This hook was introduced to follow our standard use of react-query and will be used in this [PR](#92183).
priscilawebdev
added a commit
that referenced
this pull request
Jun 3, 2025
Adds `persistInFlight` to onboarding's mutations as it was recommended [here](#92186 (comment))
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 3, 2025
Adds `persistInFlight` to onboarding's mutations as it was recommended [here](#92186 (comment))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook was introduced to follow our standard use of react-query and will be used in this PR.