fix(issues): Add upcoming release check #76864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
Sep 3, 2024
malwilley
approved these changes
Sep 3, 2024
JoshFerge
reviewed
Sep 3, 2024
| # reason the semver/date checks fail (which should not happen!) | ||
| if res_type in (None, cls.Type.in_next_release): | ||
| # todo(roggenkemper): remove upcoming_release check after we know that no group resolutions have it | ||
| if res_type in (None, cls.Type.in_next_release, cls.Type.in_upcoming_release): |
Member
There was a problem hiding this comment.
is there any test we can add for this (as a follow up).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds the check for in_upcoming_release so that we don't hit the NotImplemented, will mimic the behavior of in_next_release for now.