Skip to content

Commit 01b0e16

Browse files
authored
fix(issues): Add upcoming release check (#76864)
this pr adds the check for in_upcoming_release so that we don't hit the NotImplemented, will mimic the behavior of in_next_release for now.
1 parent 0c261fb commit 01b0e16

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/sentry/models/groupresolution.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,8 @@ def compare_release_dates_for_in_next_release(res_release, res_release_datetime,
144144
# We still fallback to the older model if either current_release_version was not set (
145145
# i.e. In all resolved cases except for Resolved in Next Release) or if for whatever
146146
# reason the semver/date checks fail (which should not happen!)
147-
if res_type in (None, cls.Type.in_next_release):
147+
# todo(roggenkemper): remove upcoming_release check after we know that no group resolutions have it
148+
if res_type in (None, cls.Type.in_next_release, cls.Type.in_upcoming_release):
148149
# Add metric here to ensure that this code branch ever runs given that
149150
# clear_expired_resolutions changes the type to `in_release` once a Release instance
150151
# is created

0 commit comments

Comments
 (0)