Skip to content

fix(issues): Add upcoming release check #76864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2024
Merged

fix(issues): Add upcoming release check #76864

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e74cf8
add back feature flag check
roggenkemper Sep 3, 2024
0ef20ba
add new check to conditional
roggenkemper Sep 3, 2024
4af6837
rm test
roggenkemper Sep 3, 2024
f5aed35
rm check
roggenkemper Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sentry/models/groupresolution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ def compare_release_dates_for_in_next_release(res_release, res_release_datetime,
# We still fallback to the older model if either current_release_version was not set (
# i.e. In all resolved cases except for Resolved in Next Release) or if for whatever
# reason the semver/date checks fail (which should not happen!)
if res_type in (None, cls.Type.in_next_release):
# todo(roggenkemper): remove upcoming_release check after we know that no group resolutions have it
if res_type in (None, cls.Type.in_next_release, cls.Type.in_upcoming_release):
Copy link
Member

@JoshFerge JoshFerge Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any test we can add for this (as a follow up).

# Add metric here to ensure that this code branch ever runs given that
# clear_expired_resolutions changes the type to `in_release` once a Release instance
# is created
Expand Down