fix(issues): Hide overlap on avatar list #58411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hides the overlap when shrinking and reduces movement by applying padding all the time
scttcper
commented
Oct 18, 2023
|
|
||
| // Using 22px + space(1) = space(4) | ||
| const SmallerSidebarWrap = styled(SidebarSection.Wrap)` | ||
| margin-bottom: 22px; |
Member
Author
There was a problem hiding this comment.
only doing this because space(3) + space(1) != space(4). for some reason sapce(3) is 20px
github-actions
bot
added
the
Scope: Frontend
NisanthanNanthakumar
approved these changes
Oct 18, 2023
roggenkemper
approved these changes
Oct 18, 2023
ceorourke
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hides the overlap when shrinking and reduces movement by applying padding all the time
before - notice the overflow is showing
after
CleanShot.2023-10-18.at.16.08.28.mp4