Skip to content

Commit 03d1596

Browse files
authored
fix(issues): Hide overlap on avatar list (#58411)
1 parent c87c851 commit 03d1596

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

static/app/views/issueDetails/groupSidebar.tsx

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ export default function GroupSidebar({
185185
);
186186

187187
return (
188-
<SidebarSection.Wrap>
188+
<SmallerSidebarWrap>
189189
<SidebarSection.Title>
190190
{t('Participants')} <TitleNumber>({getParticipantTitle()})</TitleNumber>
191191
<QuestionTooltip
@@ -215,7 +215,7 @@ export default function GroupSidebar({
215215
/>
216216
)}
217217
</SidebarSection.Content>
218-
</SidebarSection.Wrap>
218+
</SmallerSidebarWrap>
219219
);
220220
};
221221

@@ -244,7 +244,7 @@ export default function GroupSidebar({
244244
);
245245

246246
return (
247-
<SidebarSection.Wrap>
247+
<SmallerSidebarWrap>
248248
<SidebarSection.Title>
249249
{t('Viewers')}
250250
<TitleNumber>({displayUsers.length})</TitleNumber>
@@ -263,7 +263,7 @@ export default function GroupSidebar({
263263
avatars
264264
)}
265265
</SidebarSection.Content>
266-
</SidebarSection.Wrap>
266+
</SmallerSidebarWrap>
267267
);
268268
};
269269

@@ -335,3 +335,8 @@ const StyledAvatarList = styled(AvatarList)`
335335
const TitleNumber = styled('span')`
336336
font-weight: normal;
337337
`;
338+
339+
// Using 22px + space(1) = space(4)
340+
const SmallerSidebarWrap = styled(SidebarSection.Wrap)`
341+
margin-bottom: 22px;
342+
`;

static/app/views/issueDetails/participantList.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ export function ParticipantList({teams = [], users, children}: ParticipantListPr
8080
{isExpanded && (
8181
<motion.div
8282
variants={{
83-
open: {height: '100%', opacity: 1, marginTop: space(1)},
84-
closed: {height: '0', opacity: 0, marginTop: 0},
83+
open: {height: '100%', opacity: 1, overflow: 'initial'},
84+
closed: {height: '0', opacity: 0, overflow: 'hidden'},
8585
}}
8686
initial="closed"
8787
animate="open"
@@ -100,6 +100,7 @@ const ParticipantWrapper = styled('div')`
100100
align-items: center;
101101
justify-content: space-between;
102102
cursor: pointer;
103+
padding-bottom: ${space(1)};
103104
104105
& > span {
105106
cursor: pointer;

0 commit comments

Comments
 (0)