Skip to content

fix(issues): Hide overlap on avatar list #58411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix(issues): Hide overlap on avatar list #58411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions static/app/views/issueDetails/groupSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export default function GroupSidebar({
);

return (
<SidebarSection.Wrap>
<SmallerSidebarWrap>
<SidebarSection.Title>
{t('Participants')} <TitleNumber>({getParticipantTitle()})</TitleNumber>
<QuestionTooltip
Expand Down Expand Up @@ -215,7 +215,7 @@ export default function GroupSidebar({
/>
)}
</SidebarSection.Content>
</SidebarSection.Wrap>
</SmallerSidebarWrap>
);
};

Expand Down Expand Up @@ -244,7 +244,7 @@ export default function GroupSidebar({
);

return (
<SidebarSection.Wrap>
<SmallerSidebarWrap>
<SidebarSection.Title>
{t('Viewers')}
<TitleNumber>({displayUsers.length})</TitleNumber>
Expand All @@ -263,7 +263,7 @@ export default function GroupSidebar({
avatars
)}
</SidebarSection.Content>
</SidebarSection.Wrap>
</SmallerSidebarWrap>
);
};

Expand Down Expand Up @@ -335,3 +335,8 @@ const StyledAvatarList = styled(AvatarList)`
const TitleNumber = styled('span')`
font-weight: normal;
`;

// Using 22px + space(1) = space(4)
const SmallerSidebarWrap = styled(SidebarSection.Wrap)`
margin-bottom: 22px;
Copy link
Member Author

@scttcper scttcper Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only doing this because space(3) + space(1) != space(4). for some reason sapce(3) is 20px

`;
5 changes: 3 additions & 2 deletions static/app/views/issueDetails/participantList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ export function ParticipantList({teams = [], users, children}: ParticipantListPr
{isExpanded && (
<motion.div
variants={{
open: {height: '100%', opacity: 1, marginTop: space(1)},
closed: {height: '0', opacity: 0, marginTop: 0},
open: {height: '100%', opacity: 1, overflow: 'initial'},
closed: {height: '0', opacity: 0, overflow: 'hidden'},
}}
initial="closed"
animate="open"
Expand All @@ -100,6 +100,7 @@ const ParticipantWrapper = styled('div')`
align-items: center;
justify-content: space-between;
cursor: pointer;
padding-bottom: ${space(1)};

& > span {
cursor: pointer;
Expand Down