fix(dev): Do not export SENTRY_DSN in .envrc #33802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started exporting SENTRY_DSN back in #32524 in order to fix errors in lib.sh not being reported. This now prevents again the possibility of the Sentry localhost backend from reporting errors. You can see [this error](https://sentry.io/organizations/sentry/issues/3211262306/?project=5723503&query=is%3Aunresolved&statsPeriod=1h) as an example.
armenzg
added
the
Component: Developer Environment
asottile-sentry
added a commit
that referenced
this pull request
Apr 21, 2022
This reverts commit adac2e4.
asottile-sentry
added a commit
that referenced
this pull request
Apr 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started exporting SENTRY_DSN back in #32524 in order to fix errors in lib.sh not being reported.
This now prevents again the possibility of the Sentry localhost backend from reporting errors.
You can see this error as an example.