Skip to content

Revert "fix(dev): Do not export SENTRY_DSN in .envrc" #33826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2022
Merged

Revert "fix(dev): Do not export SENTRY_DSN in .envrc" #33826

merged 1 commit into from
Apr 21, 2022

Conversation

@asottile-sentry
Copy link
Contributor

@asottile-sentry asottile-sentry commented Apr 21, 2022

Reverts #33802

this appears to be breaking direnv for me (and others):

$ git branch
  asottile-stylelint-fix
  asottile-warn-docker-memory
  asottile-yesqa
* master
$ git rev-parse HEAD
0399f61e6d209605fa7c11e4ee289748cb4b9b4a
$ cd -
/Users/asottile/workspace
direnv: unloading
$ cd -
/Users/asottile/workspace/sentry
direnv: loading ~/workspace/sentry/.envrc
SUCCESS!
$ which python
$

@asottile-sentry asottile-sentry requested a review from a team as a code owner April 21, 2022 15:16
@asottile-sentry asottile-sentry merged commit ac50861 into master Apr 21, 2022
@asottile-sentry asottile-sentry deleted the revert-33802-armenzg/dev/sentry-dsn branch April 21, 2022 15:55
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asottile-sentry @Zylphrex