fix(dev): Errors within lib.sh were not being reported to Sentry #32524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was regressed in #24512
armenzg
added
the
Component: Developer Environment
Member
Author
|
This could probably be tested by setting up a local instance, creating a make target to produce an error and check that the error shows within the DB. |
billyvg
approved these changes
Mar 11, 2022
armenzg
added a commit
that referenced
this pull request
Mar 11, 2022
…ariable It seems I didn't undo this change and got introduced in #32524
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was regressed in #24512