Skip to content

feat(docker): Switch to a distroless base image #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat(docker): Switch to a distroless base image #4940

wants to merge 7 commits into from

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Jul 15, 2025 •
edited
Loading

Switches the docker image to a distroless variant.

Refs: #4871

@Dav1dde Dav1dde self-assigned this Jul 15, 2025
@Dav1dde Dav1dde added the Trigger: Full-CI Runs all CI steps in a PR label Jul 15, 2025
@Dav1dde Dav1dde force-pushed the dav1d/distroless branch from 0baaadf to ee2b199 Compare July 15, 2025 13:52
@Dav1dde Dav1dde force-pushed the dav1d/distroless branch from ee2b199 to 9151566 Compare July 15, 2025 14:02
@Dav1dde Dav1dde force-pushed the dav1d/distroless branch 3 times, most recently from b70ec3b to a3534a2 Compare July 16, 2025 07:18
@Dav1dde Dav1dde force-pushed the dav1d/distroless branch from a3534a2 to c7aac11 Compare July 16, 2025 07:53
aldy505
aldy505 reviewed Jul 17, 2025
View reviewed changes
@Dav1dde @aldy505
Update .github/workflows/ci.yml
c1f6001 
Co-authored-by: Reinaldy Rafli <[email protected]>
@aldy505
Copy link
Contributor

aldy505 commented Jul 17, 2025

there you go

relay-1                            | error: 'relay' requires a subcommand but one was not provided
relay-1                            |   [subcommands: run, credentials, config, generate-completions]
relay-1                            | 
relay-1                            | Usage: relay [OPTIONS] <COMMAND>
relay-1                            | 
relay-1                            | For more information, try '--help'.

aldy505
aldy505 reviewed Jul 17, 2025
View reviewed changes
@aldy505 aldy505 mentioned this pull request Jul 18, 2025
Merged
BYK pushed a commit to getsentry/self-hosted that referenced this pull request Jul 19, 2025
@aldy505
feat: inspect docker compose failure on self-hosted e2e action (#3817)
9fbd722 
It's hard to debug docker compose failure on other repositories since they can't see the `docker compose ps` and `docker compose logs`. One problem occurred here: getsentry/relay#4940

This PR aims to provide both commands if failure happens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldy505 aldy505 aldy505 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Dav1dde Dav1dde

Labels
do not merge Trigger: Full-CI Runs all CI steps in a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dav1dde @aldy505