This repository was archived by the owner on Jan 20, 2025. It is now read-only.
docs: update style-guide #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirotaka
requested review from
Naturalclar,
smorimoto and
uetchy
as code owners
uetchy
reviewed
Jan 17, 2020
style-guide.md
Outdated
| ❌ ダメかも： | ||
|
|
||
| ```md | ||
| もし React について詳しくなければ、まずは[こちらのガイド](https://reactjs.org)をご覧ください。 |
Contributor
There was a problem hiding this comment.
良いとダメかもが同じに見えますがどの部分が変わっていますか？
hirotaka
commented
Jan 17, 2020
uetchy
previously approved these changes
Jan 17, 2020
uetchy
added
the
status: awaiting more approval
Naturalclar
previously approved these changes
Jan 22, 2020
Contributor
|
あら、コンフリクトしているのでその解消をお願いします:pray: |
Naturalclar
added
status: awaiting author response
smorimoto
added
status: awaiting more approval
smorimoto
approved these changes
Jan 23, 2020
uetchy
approved these changes
Jan 23, 2020
uetchy
removed
status: awaiting more approval
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
下記に関連して、「""」「``」の間にスペースをいれるのが現状だとtextlintで検知できないので、取り急ぎ記載があった方がいいと思ったので追記しました。
#27
チェックリスト
textlintを使って校正を行いました（推奨）Allow edits from maintainersにチェックを入れました。しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。