Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@hirotaka
Copy link
Contributor

No description provided.

Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 16, 2020
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Yasuaki Uechi <[email protected]>
uetchy
uetchy previously approved these changes Jan 16, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 16, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳は全体的に良いと思います!
半角と全角の間のスペースだけ追加したいです:bow:
quotation とかで囲まれてても Lint に反応させたい‥

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
@hirotaka
Copy link
Contributor Author

ありがとうございます!なんかお手間を取らせてしまって恐縮です。
textlintでできるよのがいいのですが、取り急ぎstyle-guideの方に追記してみました。
#68

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます!

@Naturalclar Naturalclar merged commit 6157877 into master Jan 19, 2020
@Naturalclar Naturalclar deleted the tutorial/part-one branch January 19, 2020 02:56
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants