Allow GTK style enum naming #56731
Allow GTK style enum naming #56731
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
I didn't remove the lint disabling in the public headers, as I'm not sure if this would affect the apps that use them to generate warnings - does anyone know if this is appropriate? |
I'd assume the onus would be on users to opt their tooling out of linting third-party headers. That doesn't mean people aren't doing this, but I'd imagine that they'd run into this with other libraries as well. |
|
test-exempt: enforced by configuration change |
…159263) flutter/engine@69c3255...523d381 2024-11-21 [email protected] [Flutter GPU] Added support to set Scissor. (flutter/engine#56302) 2024-11-21 [email protected] Enable view focus (flutter/engine#54966) 2024-11-21 [email protected] Allow GTK style enum naming (flutter/engine#56731) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Remove the linting overrides for enum names and set this in the clang-format file.
3 participants
Remove the linting overrides for enum names and set this in the clang-format file.