Split channel messaging out of handlers #56667
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: code refactor with no semantic change |
| // NOLINTBEGIN(readability-identifier-naming) | ||
| FL_PLATFORM_CHANNEL_EXIT_TYPE_CANCELABLE, | ||
| FL_PLATFORM_CHANNEL_EXIT_TYPE_REQUIRED, | ||
| // NOLINTEND(readability-identifier-naming) |
There was a problem hiding this comment.
Do we need to change enum naming lint rules for //flutter/shell/platform/linux/*? The linux embedder has its own .clang-tidy file here:
https://github.com/flutter/engine/blob/main/shell/platform/linux/.clang-tidy
…159226) flutter/engine@3828681...2d32cf3 2024-11-20 [email protected] [DisplayList] migrate DlImageFilter code to Impeller geometry classes (flutter/engine#56720) 2024-11-20 [email protected] Split channel messaging out of handlers (flutter/engine#56667) 2024-11-20 [email protected] Revert "Added assert for opengles thread safety (#56585)" (flutter/engine#56730) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Split the channel messaging out of the system channels to make them simpler to understand and refactor. The new channel classes could be automatically generated in a second phase, e.g. using Pigeon to reduce code usage. The new classes don't have tests as they will already be covered by the existing code.
3 participants
Split the channel messaging out of the system channels to make them simpler to understand and refactor.
The new channel classes could be automatically generated in a second phase, e.g. using Pigeon to reduce code usage.
The new classes don't have tests as they will already be covered by the existing code.