This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Flutter GPU] Added support to set Scissor. #56302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AthulJoseph27
changed the title
AthulJoseph27
force-pushed
the
scissor
branch
from
bb74927 to
64f51e3
Compare
chinmaygarde
approved these changes
Nov 1, 2024
Member
|
The goldens didn't upload for this... not sure why. |
bdero
suggested changes
Nov 1, 2024
bdero
reviewed
Nov 2, 2024
AthulJoseph27
force-pushed
the
scissor
branch
from
8951c6d to
6636a34
Compare
bdero
suggested changes
Nov 4, 2024
bdero
suggested changes
Nov 4, 2024
AthulJoseph27
force-pushed
the
scissor
branch
from
c68bcae to
33cdd6d
Compare
AthulJoseph27
force-pushed
the
scissor
branch
from
33cdd6d to
a967f2a
Compare
bdero
reviewed
Nov 13, 2024
bdero
reviewed
Nov 15, 2024
AthulJoseph27
force-pushed
the
scissor
branch
from
06f7e74 to
f788fd3
Compare
AthulJoseph27
force-pushed
the
scissor
branch
from
c081865 to
2d0d884
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 21, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 21, 2024
…159263) flutter/engine@69c3255...523d381 2024-11-21 [email protected] [Flutter GPU] Added support to set Scissor. (flutter/engine#56302) 2024-11-21 [email protected] Enable view focus (flutter/engine#54966) 2024-11-21 [email protected] Allow GTK style enum naming (flutter/engine#56731) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Added support to set scissors. This resolves issue flutter#157199
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to set scissors. This resolves issue #157199