Starts looking for the bdf fast path in relation to the snapshot_entity's transform #55890

gaaclarke · 2024-10-15T22:46:38Z

testing: performance change covered by existing benchmarks.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…ty's transform

flutter-dashboard · 2024-10-15T22:46:41Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

jonahwilliams

LGTM

auto-submit · 2024-10-16T17:05:19Z

auto label is removed for flutter/engine/55890, due to - The status or check suite Linux linux_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

jonahwilliams · 2024-10-16T17:53:04Z

impeller/geometry/matrix.h


  std::optional<MatrixDecomposition> Decompose() const;

+  bool Equals(const Matrix& matrix, Scalar epsilon = 1e-5f) const {


We have an existing scalar nearly equal method you could use instead?

Done, I also expanded ScalarNearlyEquals to use fabsf since it will be faster

jonahwilliams

LGTM

jonahwilliams · 2024-10-16T18:10:51Z

I think this bug is in the release branch, so please file a cherry pick request after this lands and we confirm the regression is fixed.

flutter-dashboard · 2024-10-16T20:00:00Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #55890 at sha 60cb8d3

…pshot_entity's transform (flutter/engine#55890)

…ty's transform (flutter#55890) fixes flutter/flutter#156871 testing: performance change covered by existing benchmarks. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

gaaclarke · 2024-10-16T21:59:44Z

Cherry-pick request filed: flutter/flutter#157060

…pshot_entity's transform (flutter/engine#55890)

…ions) (#157066) Manual roll requested by [email protected] Cannot build log URL because revision "f12e0d385f4d" is invalid: Luci builds of "Linux Web Framework tests" for f12e0d385f4d64765ed46c7c3ac8fa7fa8bc3c43 was FAILURE 2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "update the repo references for package:file (#55906)" (flutter/engine#55916) 2024-10-16 [email protected] Roll Skia from 09917e06158b to 3a081993e2a7 (3 revisions) (flutter/engine#55911) 2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d916a5f69a48 to 2bf0f2b8d391 (24 revisions) (#55884)" (flutter/engine#55915) 2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 2bf0f2b8d391 to 7fce3544047c (4 revisions) (#55896)" (flutter/engine#55914) 2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7fce3544047c to 148b7c530657 (3 revisions) (#55903)" (flutter/engine#55913) 2024-10-16 [email protected] update the repo references for package:file (flutter/engine#55906) 2024-10-16 [email protected] Handle out-of-order add/remove pointer events (flutter/engine#55740) 2024-10-16 [email protected] Starts looking for the bdf fast path in relation to the snapshot_entity's transform (flutter/engine#55890) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ions) (flutter#157066) Manual roll requested by [email protected] Cannot build log URL because revision "f12e0d385f4d" is invalid: Luci builds of "Linux Web Framework tests" for f12e0d385f4d64765ed46c7c3ac8fa7fa8bc3c43 was FAILURE 2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "update the repo references for package:file (flutter#55906)" (flutter/engine#55916) 2024-10-16 [email protected] Roll Skia from 09917e06158b to 3a081993e2a7 (3 revisions) (flutter/engine#55911) 2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d916a5f69a48 to 2bf0f2b8d391 (24 revisions) (flutter#55884)" (flutter/engine#55915) 2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 2bf0f2b8d391 to 7fce3544047c (4 revisions) (flutter#55896)" (flutter/engine#55914) 2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7fce3544047c to 148b7c530657 (3 revisions) (flutter#55903)" (flutter/engine#55913) 2024-10-16 [email protected] update the repo references for package:file (flutter/engine#55906) 2024-10-16 [email protected] Handle out-of-order add/remove pointer events (flutter/engine#55740) 2024-10-16 [email protected] Starts looking for the bdf fast path in relation to the snapshot_entity's transform (flutter/engine#55890) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…_entity's transform (#55890) (#55917) cherry-picks #55890 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…ty's transform (flutter/engine#55890) fixes flutter#156871 testing: performance change covered by existing benchmarks. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Starts looking for the bdf fast path in relation to the snapshot_enti…

7995974

…ty's transform

github-actions bot added the e: impeller label Oct 15, 2024

jonahwilliams approved these changes Oct 15, 2024

View reviewed changes

added fuzzy equals

e8b6ec6

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2024

gaaclarke added 2 commits October 16, 2024 10:08

float literal

dc1847f

format

2aa14f1

jonahwilliams reviewed Oct 16, 2024

View reviewed changes

moved to using scalarnearlyequal

60cb8d3

jonahwilliams approved these changes Oct 16, 2024

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2024

flutter-dashboard bot added the will affect goldens label Oct 16, 2024

auto-submit bot merged commit ad61c53 into flutter:main Oct 16, 2024
33 checks passed

engine-flutter-autoroll mentioned this pull request Oct 16, 2024

Roll Flutter Engine from f6fd2cbe4773 to a5f2a1a5e1af (2 revisions) flutter/flutter#157057

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 16, 2024

ad61c530d Starts looking for the bdf fast path in relation to the sna…

885f860

…pshot_entity's transform (flutter/engine#55890)

gaaclarke mentioned this pull request Oct 16, 2024

[CP] Starts looking for the bdf fast path in relation to the snapshot_entity's transform (#55890) #55917

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Oct 16, 2024

Manual roll Flutter Engine from f6fd2cbe4773 to f12e0d385f4d (8 revisions) flutter/flutter#157066

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 16, 2024

ad61c530d Starts looking for the bdf fast path in relation to the sna…

499bf7c

…pshot_entity's transform (flutter/engine#55890)

engine-flutter-autoroll mentioned this pull request Oct 16, 2024

Roll Flutter Engine from f6fd2cbe4773 to fe01035ff8d4 (5 revisions) flutter/flutter#157067

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 16, 2024

ad61c530d Starts looking for the bdf fast path in relation to the sna…

c95705a

…pshot_entity's transform (flutter/engine#55890)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Starts looking for the bdf fast path in relation to the snapshot_entity's transform #55890

Starts looking for the bdf fast path in relation to the snapshot_entity's transform #55890

Uh oh!

gaaclarke commented Oct 15, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Oct 15, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

auto-submit bot commented Oct 16, 2024

Uh oh!

jonahwilliams Oct 16, 2024

Uh oh!

gaaclarke Oct 16, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

jonahwilliams commented Oct 16, 2024

Uh oh!

flutter-dashboard bot commented Oct 16, 2024

Uh oh!

Uh oh!

gaaclarke commented Oct 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		std::optional<MatrixDecomposition> Decompose() const;

		bool Equals(const Matrix& matrix, Scalar epsilon = 1e-5f) const {

Starts looking for the bdf fast path in relation to the snapshot_entity's transform #55890

Starts looking for the bdf fast path in relation to the snapshot_entity's transform #55890

Uh oh!

Conversation

gaaclarke commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Oct 15, 2024

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Oct 16, 2024

Uh oh!

jonahwilliams Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

gaaclarke Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented Oct 16, 2024

Uh oh!

flutter-dashboard bot commented Oct 16, 2024

Uh oh!

Uh oh!

gaaclarke commented Oct 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gaaclarke commented Oct 15, 2024 •

edited

Loading