Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Oct 16, 2024

Reverts: #55884

Initiated by: zanderso

Reason for reverting: b/373907578

Original PR Author: a-siva

Reviewed By: {srawlins, zanderso}

This change reverts the following previous change:
Manual roll requested by [email protected]

https://dart.googlesource.com/sdk.git/+log/d916a5f69a48..2bf0f2b8d391

2024-10-15 [email protected] Version 3.7.0-23.0.dev
2024-10-14 [email protected] Version 3.7.0-22.0.dev
2024-10-14 [email protected] Version 3.7.0-21.0.dev
2024-10-14 [email protected] Version 3.7.0-20.0.dev
2024-10-12 [email protected] Version 3.7.0-19.0.dev
2024-10-12 [email protected] Version 3.7.0-18.0.dev
2024-10-12 [email protected] Version 3.7.0-17.0.dev
2024-10-12 [email protected] Version 3.7.0-16.0.dev
2024-10-11 [email protected] Version 3.7.0-15.0.dev
2024-10-11 [email protected] Version 3.7.0-14.0.dev
2024-10-11 [email protected] Version 3.7.0-13.0.dev
2024-10-11 [email protected] Version 3.7.0-12.0.dev
2024-10-10 [email protected] Version 3.7.0-11.0.dev
2024-10-10 [email protected] Version 3.7.0-10.0.dev
2024-10-10 [email protected] Version 3.7.0-9.0.dev
2024-10-10 [email protected] Version 3.7.0-8.0.dev
2024-10-10 [email protected] Version 3.7.0-7.0.dev
2024-10-09 [email protected] Version 3.7.0-6.0.dev
2024-10-09 [email protected] Version 3.7.0-5.0.dev
2024-10-09 [email protected] Version 3.7.0-4.0.dev
2024-10-09 [email protected] Version 3.7.0-3.0.dev
2024-10-09 [email protected] Version 3.7.0-2.0.dev
2024-10-09 [email protected] Version 3.7.0-1.0.dev
2024-10-08 [email protected] Version 3.7.0-0.0.dev

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Oct 16, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@zanderso
Copy link
Member

cc @jacobsimionato @a-siva @bkonyi

@auto-submit auto-submit bot merged commit a74d9ab into main Oct 16, 2024
6 checks passed
@auto-submit auto-submit bot deleted the revert_acc219979dcf28726e7f2240b91e618ed6e92cc2 branch October 16, 2024 21:13
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 16, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 17, 2024
…ions) (#157066)

Manual roll requested by [email protected]

Cannot build log URL because revision "f12e0d385f4d" is invalid: Luci builds of "Linux Web Framework tests" for f12e0d385f4d64765ed46c7c3ac8fa7fa8bc3c43 was FAILURE

2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "update the repo references for package:file (#55906)" (flutter/engine#55916)
2024-10-16 [email protected] Roll Skia from 09917e06158b to 3a081993e2a7 (3 revisions) (flutter/engine#55911)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d916a5f69a48 to 2bf0f2b8d391 (24 revisions) (#55884)" (flutter/engine#55915)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 2bf0f2b8d391 to 7fce3544047c (4 revisions) (#55896)" (flutter/engine#55914)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7fce3544047c to 148b7c530657 (3 revisions) (#55903)" (flutter/engine#55913)
2024-10-16 [email protected] update the repo references for package:file (flutter/engine#55906)
2024-10-16 [email protected] Handle out-of-order add/remove pointer events (flutter/engine#55740)
2024-10-16 [email protected] Starts looking for the bdf fast path in relation to the snapshot_entity's transform (flutter/engine#55890)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Lurchfresser pushed a commit to Lurchfresser/flutter that referenced this pull request Oct 17, 2024
…ions) (flutter#157066)

Manual roll requested by [email protected]

Cannot build log URL because revision "f12e0d385f4d" is invalid: Luci builds of "Linux Web Framework tests" for f12e0d385f4d64765ed46c7c3ac8fa7fa8bc3c43 was FAILURE

2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "update the repo references for package:file (flutter#55906)" (flutter/engine#55916)
2024-10-16 [email protected] Roll Skia from 09917e06158b to 3a081993e2a7 (3 revisions) (flutter/engine#55911)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d916a5f69a48 to 2bf0f2b8d391 (24 revisions) (flutter#55884)" (flutter/engine#55915)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 2bf0f2b8d391 to 7fce3544047c (4 revisions) (flutter#55896)" (flutter/engine#55914)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7fce3544047c to 148b7c530657 (3 revisions) (flutter#55903)" (flutter/engine#55913)
2024-10-16 [email protected] update the repo references for package:file (flutter/engine#55906)
2024-10-16 [email protected] Handle out-of-order add/remove pointer events (flutter/engine#55740)
2024-10-16 [email protected] Starts looking for the bdf fast path in relation to the snapshot_entity's transform (flutter/engine#55890)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…evisions) (flutter#55884)" (flutter/engine#55915)

Reverts: flutter/engine#55884
Initiated by: zanderso
Reason for reverting: b/373907578
Original PR Author: a-siva

Reviewed By: {srawlins, zanderso}

This change reverts the following previous change:
Manual roll requested by [[email protected]](mailto:[email protected])

https://dart.googlesource.com/sdk.git/+log/d916a5f69a48..2bf0f2b8d391

2024-10-15 [[email protected]](mailto:[email protected]) Version 3.7.0-23.0.dev
2024-10-14 [[email protected]](mailto:[email protected]) Version 3.7.0-22.0.dev
2024-10-14 [[email protected]](mailto:[email protected]) Version 3.7.0-21.0.dev
2024-10-14 [[email protected]](mailto:[email protected]) Version 3.7.0-20.0.dev
2024-10-12 [[email protected]](mailto:[email protected]) Version 3.7.0-19.0.dev
2024-10-12 [[email protected]](mailto:[email protected]) Version 3.7.0-18.0.dev
2024-10-12 [[email protected]](mailto:[email protected]) Version 3.7.0-17.0.dev
2024-10-12 [[email protected]](mailto:[email protected]) Version 3.7.0-16.0.dev
2024-10-11 [[email protected]](mailto:[email protected]) Version 3.7.0-15.0.dev
2024-10-11 [[email protected]](mailto:[email protected]) Version 3.7.0-14.0.dev
2024-10-11 [[email protected]](mailto:[email protected]) Version 3.7.0-13.0.dev
2024-10-11 [[email protected]](mailto:[email protected]) Version 3.7.0-12.0.dev
2024-10-10 [[email protected]](mailto:[email protected]) Version 3.7.0-11.0.dev
2024-10-10 [[email protected]](mailto:[email protected]) Version 3.7.0-10.0.dev
2024-10-10 [[email protected]](mailto:[email protected]) Version 3.7.0-9.0.dev
2024-10-10 [[email protected]](mailto:[email protected]) Version 3.7.0-8.0.dev
2024-10-10 [[email protected]](mailto:[email protected]) Version 3.7.0-7.0.dev
2024-10-09 [[email protected]](mailto:[email protected]) Version 3.7.0-6.0.dev
2024-10-09 [[email protected]](mailto:[email protected]) Version 3.7.0-5.0.dev
2024-10-09 [[email protected]](mailto:[email protected]) Version 3.7.0-4.0.dev
2024-10-09 [[email protected]](mailto:[email protected]) Version 3.7.0-3.0.dev
2024-10-09 [[email protected]](mailto:[email protected]) Version 3.7.0-2.0.dev
2024-10-09 [[email protected]](mailto:[email protected]) Version 3.7.0-1.0.dev
2024-10-08 [[email protected]](mailto:[email protected]) Version 3.7.0-0.0.dev
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-fuchsia revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants