Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gaaclarke
Copy link
Member

cherry-picks #55890

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

itsjustkevin and others added 2 commits September 10, 2024 19:13
…utter#55077)

# Flutter beta 3.26.0-0.1.pre Engine

## Scheduled Cherrypicks

- Roll dart revision: dart-lang/sdk@0ebf221eb
…ty's transform (flutter#55890)

fixes flutter/flutter#156871

testing: performance change covered by existing benchmarks.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
zanderso
zanderso previously approved these changes Oct 16, 2024
@zanderso
Copy link
Member

The target branch should be 3.27 not 3.26

@zanderso zanderso dismissed their stale review October 16, 2024 22:12

Wrong target branch

@gaaclarke
Copy link
Member Author

The target branch should be 3.27 not 3.26

That's not the branch pointed to in https://github.com/flutter/flutter/blob/beta/bin/internal/release-candidate-branch.version. Is that out of date?

@zanderso
Copy link
Member

The target branch should be 3.27 not 3.26

That's not the branch pointed to in https://github.com/flutter/flutter/blob/beta/bin/internal/release-candidate-branch.version. Is that out of date?

Yes, it's out of date. The correct info is here flutter/flutter#156508.

@gaaclarke gaaclarke changed the base branch from flutter-3.26-candidate.0 to flutter-3.27-candidate.0 October 16, 2024 22:29
@gaaclarke
Copy link
Member Author

The target branch should be 3.27 not 3.26

Done.

@gaaclarke gaaclarke requested a review from zanderso October 16, 2024 22:30
@gaaclarke
Copy link
Member Author

Yes, it's out of date. The correct info is here flutter/flutter#156508.

FYI the cherry-pick template points to https://github.com/flutter/flutter/blob/beta/bin/internal/release-candidate-branch.version as being the source of truth.

@gaaclarke
Copy link
Member Author

@zanderso What's the protocol for this, do you want me to merge it? I was expecting someone else to do it as part of the process for reviewing cp request.

@zanderso
Copy link
Member

No action needed. The release team will manage merging it in time for the next beta hotfix release.

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2024
@auto-submit auto-submit bot merged commit 2ad45d5 into flutter:flutter-3.27-candidate.0 Nov 5, 2024
27 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants