This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "[Impeller] Avoid loading redundant Vulkan extensions. (#51818)" #51835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6d4d546.
auto-submit
bot
added
the
revert of
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
added
the
autosubmit
fluttergithubbot
approved these changes
Apr 1, 2024
auto-submit
bot
deleted the
revert_6d4d546e4e97e195309d38bb68118834d48fe2cf
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 2, 2024
…sions) (#146108) Manual roll requested by [email protected] Cannot build log URL because revision "9a513de65251" is invalid: Luci builds of "Linux linux_android_emulator_skia_tests" for 9a513de65251f83a43d979bb0b2d4c8ee2f8c417 was FAILURE 2024-04-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Avoid loading redundant Vulkan extensions. (#51818)" (flutter/engine#51835) 2024-04-01 [email protected] Run and record `adb shell screenrecord` during Android scenario app (flutter/engine#51832) 2024-04-01 [email protected] Roll Skia from 0b0ed6ca101b to fe64c32d7f2e (4 revisions) (flutter/engine#51831) 2024-04-01 [email protected] Run the `DrawSolidBlueScreenTest` 5x in a row in bringup builds. (flutter/engine#51829) 2024-04-01 [email protected] Remove tests related to StrictMode that were never running on CI. (flutter/engine#51827) 2024-04-01 [email protected] [Impeller] Ignore warnign about shader stages not consuming outputs. (flutter/engine#51822) 2024-04-01 [email protected] [Skwasm] Forward text height from paragraph height to default text style (flutter/engine#51819) 2024-04-01 [email protected] Remove log statements that did not help. (flutter/engine#51825) 2024-04-01 [email protected] Roll Skia from 40c436a785fa to 0b0ed6ca101b (6 revisions) (flutter/engine#51823) 2024-04-01 [email protected] [Impeller] Add a TextureGLES API for wrapping a framebuffer and use it to implement OpenGL FBO targets in the embedder library (flutter/engine#51269) 2024-04-01 [email protected] Remove `testing/android_background_image` which does not run/exist on CI. (flutter/engine#51815) 2024-04-01 [email protected] [Impeller] Avoid loading redundant Vulkan extensions. (flutter/engine#51818) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #51818
Initiated by: chinmaygarde
Reason for reverting: VK_EXT_queue_family_foreign needs to be explicitly enabled even though the documentation stays that 1.1 is a dependency (https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_queue_family_foreign.html#_extension_and_version_dependencies). Broke validation enabled builds downstream. https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20hello_world_impeller/3118/ov
Original PR Author: chinmaygarde
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
All dependencies of VK_ANDROID_external_memory_android_hardware_buffer were enabled earlier. But I didn't realize that those extensions became core in Vulkan 1.1. There is no need to load them unnecessarily. It just makes the extensions requirements look more complicated than they are.
Just deletes code. No change in functionality.