Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 6d4d546

Browse files
authored
[Impeller] Avoid loading redundant Vulkan extensions. (#51818)
All dependencies of VK_ANDROID_external_memory_android_hardware_buffer were enabled earlier. But I didn't realize that those extensions became core in Vulkan 1.1. There is no need to load them unnecessarily. It just makes the extensions requirements look more complicated than they are. Just deletes code. No change in functionality.
1 parent e6f1940 commit 6d4d546

File tree

2 files changed

+1
-39
lines changed

2 files changed

+1
-39
lines changed

impeller/renderer/backend/vulkan/capabilities_vk.cc

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -167,14 +167,6 @@ static const char* GetExtensionName(RequiredAndroidDeviceExtensionVK ext) {
167167
case RequiredAndroidDeviceExtensionVK::
168168
kANDROIDExternalMemoryAndroidHardwareBuffer:
169169
return "VK_ANDROID_external_memory_android_hardware_buffer";
170-
case RequiredAndroidDeviceExtensionVK::kKHRSamplerYcbcrConversion:
171-
return VK_KHR_SAMPLER_YCBCR_CONVERSION_EXTENSION_NAME;
172-
case RequiredAndroidDeviceExtensionVK::kKHRExternalMemory:
173-
return VK_KHR_EXTERNAL_MEMORY_EXTENSION_NAME;
174-
case RequiredAndroidDeviceExtensionVK::kEXTQueueFamilyForeign:
175-
return VK_EXT_QUEUE_FAMILY_FOREIGN_EXTENSION_NAME;
176-
case RequiredAndroidDeviceExtensionVK::kKHRDedicatedAllocation:
177-
return VK_KHR_DEDICATED_ALLOCATION_EXTENSION_NAME;
178170
case RequiredAndroidDeviceExtensionVK::kLast:
179171
return "Unknown";
180172
}
@@ -373,9 +365,7 @@ CapabilitiesVK::GetEnabledDeviceFeatures(
373365
required.fillModeNonSolid = supported.fillModeNonSolid;
374366
}
375367
// VK_KHR_sampler_ycbcr_conversion features.
376-
if (IsExtensionInList(
377-
enabled_extensions.value(),
378-
RequiredAndroidDeviceExtensionVK::kKHRSamplerYcbcrConversion)) {
368+
{
379369
auto& required =
380370
required_chain
381371
.get<vk::PhysicalDeviceSamplerYcbcrConversionFeaturesKHR>();

impeller/renderer/backend/vulkan/capabilities_vk.h

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -50,34 +50,6 @@ enum class RequiredAndroidDeviceExtensionVK : uint32_t {
5050
///
5151
kANDROIDExternalMemoryAndroidHardwareBuffer,
5252

53-
//----------------------------------------------------------------------------
54-
/// Dependency of kANDROIDExternalMemoryAndroidHardwareBuffer.
55-
///
56-
/// https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_sampler_ycbcr_conversion.html
57-
///
58-
kKHRSamplerYcbcrConversion,
59-
60-
//----------------------------------------------------------------------------
61-
/// Dependency of kANDROIDExternalMemoryAndroidHardwareBuffer.
62-
///
63-
/// https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_external_memory.html
64-
///
65-
kKHRExternalMemory,
66-
67-
//----------------------------------------------------------------------------
68-
/// Dependency of kANDROIDExternalMemoryAndroidHardwareBuffer.
69-
///
70-
/// https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_queue_family_foreign.html
71-
///
72-
kEXTQueueFamilyForeign,
73-
74-
//----------------------------------------------------------------------------
75-
/// Dependency of kANDROIDExternalMemoryAndroidHardwareBuffer.
76-
///
77-
/// https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_dedicated_allocation.html
78-
///
79-
kKHRDedicatedAllocation,
80-
8153
kLast,
8254
};
8355

0 commit comments

Comments
 (0)