This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Implement PlatformDispatcher.requestViewFocusChange on web. #50535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Feb 15, 2024
ditman
reviewed
Feb 15, 2024
tugorez
commented
Feb 15, 2024
lib/web_ui/test/engine/view_embedder/global_html_attributes_test.dart
Outdated
Show resolved
Hide resolved
ditman
approved these changes
Mar 9, 2024
Member
ditman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 13, 2024
…145106) flutter/engine@6ceccf8...9551b49 2024-03-13 [email protected] [Impeller] fix heap selection process for YUV textures. (flutter/engine#51262) 2024-03-13 6844906[email protected] [Fuchsia] Enable sound null safety everywhere (flutter/engine#51355) 2024-03-13 [email protected] [Impeller] added missing golden test for DrawScaledTextWithPerspectiveSaveLayer (flutter/engine#51368) 2024-03-13 [email protected] Roll Skia from dc7443fa4d88 to 1ad0d0fabe7a (1 revision) (flutter/engine#51373) 2024-03-13 [email protected] Implement PlatformDispatcher.requestViewFocusChange on web. (flutter/engine#50535) 2024-03-13 [email protected] [Impeller] attempt to get validation errors from CI unittests. (flutter/engine#51341) 2024-03-13 [email protected] Roll Dart SDK from b19e0995f317 to 18ec60df0774 (1 revision) (flutter/engine#51374) 2024-03-13 [email protected] [scenario app] make image matching fuzzier. (flutter/engine#51376) 2024-03-13 [email protected] Roll Skia from bbe453e3525d to dc7443fa4d88 (1 revision) (flutter/engine#51371) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
platform-web
Code specifically for the web engine
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement PlatformDispatcher.requestViewFocusChange on web.
Relevant Issues are:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.