[Impeller] fix heap selection process for YUV textures. #51262
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Good hunch. |
|
@chinmaygarde this probably impacts the AHB based swapchain too. We should confirm that emulators can actually import AHB, and if not then we need to escalate to the Android team because that seems oddly limiting. |
|
To be honest, I sort of just assumed the heap selection was fine since @johnmccutchan wired it up and I was always running to crashes on emulators. It also JustWorked™ on the devices. So I have spent zero time reasoning about the correctness of the heap selection during import. I'll take a closer look now. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
added
the
autosubmit
…145106) flutter/engine@6ceccf8...9551b49 2024-03-13 [email protected] [Impeller] fix heap selection process for YUV textures. (flutter/engine#51262) 2024-03-13 6844906[email protected] [Fuchsia] Enable sound null safety everywhere (flutter/engine#51355) 2024-03-13 [email protected] [Impeller] added missing golden test for DrawScaledTextWithPerspectiveSaveLayer (flutter/engine#51368) 2024-03-13 [email protected] Roll Skia from dc7443fa4d88 to 1ad0d0fabe7a (1 revision) (flutter/engine#51373) 2024-03-13 [email protected] Implement PlatformDispatcher.requestViewFocusChange on web. (flutter/engine#50535) 2024-03-13 [email protected] [Impeller] attempt to get validation errors from CI unittests. (flutter/engine#51341) 2024-03-13 [email protected] Roll Dart SDK from b19e0995f317 to 18ec60df0774 (1 revision) (flutter/engine#51374) 2024-03-13 [email protected] [scenario app] make image matching fuzzier. (flutter/engine#51376) 2024-03-13 [email protected] Roll Skia from bbe453e3525d to dc7443fa4d88 (1 revision) (flutter/engine#51371) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This does not fix the emulator weirdness!
Today we automatically select the first memory type index requested by an AHB. The device in question may lack that memory type index, so we can then fail to import the AHB. Additionally, if we do fail we need to ensure that we don't attempt to display the texture.