This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Fuchsia] Enable sound null safety everywhere #51355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijiehe-google-com
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
alexmarkov
approved these changes
Mar 13, 2024
Contributor
alexmarkov
left a comment
alexmarkov
left a comment
There was a problem hiding this comment.
Lgtm with a few comments.
shell/platform/fuchsia/flutter/tests/integration/embedder/parent-view/lib/parent_view.dart
Show resolved
Hide resolved
...orm/fuchsia/flutter/tests/integration/mouse-input/mouse-input-view/lib/mouse-input-view.dart
Outdated
Show resolved
Hide resolved
...flutter/tests/integration/touch-input/embedding-flutter-view/lib/embedding-flutter-view.dart
Outdated
Show resolved
Hide resolved
...flutter/tests/integration/touch-input/embedding-flutter-view/lib/embedding-flutter-view.dart
Show resolved
Hide resolved
a-siva
approved these changes
Mar 13, 2024
zijiehe-google-com
added
the
autosubmit
Contributor
Author
|
Thank you Alexander and Siva. I addressed all the comments and added autosubmit label since the tree is closing now. Let me know if you have other comments. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 13, 2024
…145106) flutter/engine@6ceccf8...9551b49 2024-03-13 [email protected] [Impeller] fix heap selection process for YUV textures. (flutter/engine#51262) 2024-03-13 6844906[email protected] [Fuchsia] Enable sound null safety everywhere (flutter/engine#51355) 2024-03-13 [email protected] [Impeller] added missing golden test for DrawScaledTextWithPerspectiveSaveLayer (flutter/engine#51368) 2024-03-13 [email protected] Roll Skia from dc7443fa4d88 to 1ad0d0fabe7a (1 revision) (flutter/engine#51373) 2024-03-13 [email protected] Implement PlatformDispatcher.requestViewFocusChange on web. (flutter/engine#50535) 2024-03-13 [email protected] [Impeller] attempt to get validation errors from CI unittests. (flutter/engine#51341) 2024-03-13 [email protected] Roll Dart SDK from b19e0995f317 to 18ec60df0774 (1 revision) (flutter/engine#51374) 2024-03-13 [email protected] [scenario app] make image matching fuzzier. (flutter/engine#51376) 2024-03-13 [email protected] Roll Skia from bbe453e3525d to dc7443fa4d88 (1 revision) (flutter/engine#51371) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables null_safety on fuchsia everywhere and remove the legacy conditions.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.