This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Document the capabilities. #45253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 29, 2023
impeller/renderer/capabilities.h
Outdated
| /// Example of reading from the first color attachment in a GLSL | ||
| /// shader: | ||
| /// ``` | ||
| /// layout(set = 0, binding = 0, input_attachment_index = 0) |
Member
There was a problem hiding this comment.
Nit: You can skip the layout attributes as the compiler will autogenerate them. We don't usually need or set them in Impeller.
bdero
force-pushed
the
bdero/document-capabilities
branch
from
69cd778 to
187e83c
Compare
bdero
force-pushed
the
bdero/document-capabilities
branch
from
187e83c to
9a614c5
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2023
…133618) flutter/engine@9f2cf5c...749e67a 2023-08-29 [email protected] [Impeller] Document the capabilities. (flutter/engine#45253) 2023-08-29 [email protected] [flutter roll] Revert "ios: remove shared_application and support app extension build" (flutter/engine#45250) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Add docstrings for the capabilities. Include examples/extra detail for the more confusing concepts. Also renames a couple of capabilities for consistency with format terminology: * SupportsDecalTileMode -> SupportsDecalSamplerAddressMode * SupportsMemorylessTextures -> SupportsDeviceTransientTextures PR is built on flutter#45240 (waiting for tree to reopen).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docstrings for the capabilities. Include examples/extra detail for the more confusing concepts.
Also renames a couple of capabilities for consistency with format terminology:
PR is built on #45240 (waiting for tree to reopen).